Marlin: [bugfix-1.1.x] Anet LCD 2004 Up and Down buttons are reversed

[MikeLud]

The current bugfix-1.1.x that I download today (72df10c) has the LCD 2004 Up and Down buttons reversed.

Thanks,
Mike

[Bob-the-Kuhn]

Please post your configuration.h file so we know for sure what LCD and motherboard you are using.

[MikeLud]

Anet A8 configuration.h file
Configuration.zip

[Bob-the-Kuhn]

I can't find where those buttons were changed after the LCD was added to Marlin.

Go into your pins_ANET_10.h file and make the changes. Once you've tested the changes please post the before & after files.

I'm a little concerned that there is something unique about your setup and what works for you may not work for others. I'll propose the changes but wait to see if anyone objects before merging.

[benlye]

The min/max ADC values for each button on the 5-button panel are defined in ultralcd.cpp:
https://github.com/MarlinFirmware/Marlin/blob/bugfix-1.1.x/Marlin/ultralcd.cpp#L5559

@MikeLud You can enable ADC_KEYPAD_DEBUG by adding #define ADC_KEYPAD_DEBUG somewhere in configuration.h to see the actual value reported when a button is pushed.

I'll dust off my A8 board and LCD tomorrow and see if I can repro the issue.

[MikeLud]

Before the below commit the buttons works fine, looks like this is what causes the buttons to reverse https://github.com/MarlinFirmware/Marlin/commit/70e9c07b2d888aba3e24aefac174e246e620d2d5

[thinkyhead]

I've just patched (well, finished) scroll_screen so it sets the menu direction and multiplier. This should now be fixed.

[benlye]

That fixed it for me.

[MikeLud]

Just loaded and buttons are back to normal.

Thanks