Marlin: NeoPixels with NEOPIXEL_STARTUP_TEST causes bootloop

[NiklasOlofsson]

Bug Report

• Description: Using NEOPIXEL_LED (type NEO_GRB) with NEOPIXEL_STARTUP_TEST enabled, the printer bootloops. With NEOPIXEL_STARTUP_TEST disabled the printer boots and the colors work (including blue)
• Expected behaviour: LEDs should cycle colors on printer startup
• Actual behaviour: LEDs displays red, green and then the firmware reboots, nothing on the LCD. It never shows blue color.
• Steps to reproduce:
  
  
  
  • Enable NEOPIXEL_LED
  
  
  • Enable NEOPIXEL_TYPE NEO_GRB
  
  
  • Enable NEOPIXEL_STARTUP_TEST
  
  

Configuration.zip

Not getting green at the end btw. Does Marlin look for some specific end gcode?

*Marlin 1.1.6 stable

[AnHardt]

Without having looked at the actual code:
Watchdog is already active but not refreshed in your long lasting (>3s) procedure.

[Tannoo]

I had the same.
I did this to mine (in neopixel.cpp) to make it work.

void setup_neopixel() {
  pixels.setBrightness(NEOPIXEL_BRIGHTNESS); // 0 - 255 range
  pixels.begin();
  pixels.show(); // initialize to all off

  #if ENABLED(NEOPIXEL_STARTUP_TEST)
    delay(2000);
    #if ENABLED(USE_WATCHDOG)
      watchdog_reset();
    #endif
    neopixel_set_led_color(255, 0, 0, 0, 255);  // red
    delay(2000);
    #if ENABLED(USE_WATCHDOG)
      watchdog_reset();
    #endif
    neopixel_set_led_color(0, 255, 0, 0, 255);  // green
    delay(2000);
    #if ENABLED(USE_WATCHDOG)
      watchdog_reset();
    #endif
    neopixel_set_led_color(0, 0, 255, 0, 255);  // blue
    delay(2000);
    #if ENABLED(USE_WATCHDOG)
      watchdog_reset();
    #endif
  #endif
  neopixel_set_led_color(0, 0, 0, 255, 255);    // white
}

[AnHardt]

Someone promised this.
https://www.youtube.com/watch?v=YxvBPH4sArQ from about 1:46
Do you remember? :-(

[Tannoo]

Yup. Lol

[Tannoo]

I've changed this to what it should have been:

void setup_neopixel() {
  pixels.setBrightness(NEOPIXEL_BRIGHTNESS); // 0 - 255 range
  pixels.begin();
  pixels.show(); // initialize to all off

  #if ENABLED(NEOPIXEL_STARTUP_TEST)
    safe_delay(2000);
    neopixel_set_led_color(255, 0, 0, 0, 255);  // red
    safe_delay(2000);
    neopixel_set_led_color(0, 255, 0, 0, 255);  // green
    safe_delay(2000);
    neopixel_set_led_color(0, 0, 255, 0, 255);  // blue
    safe_delay(2000);
  #endif
  neopixel_set_led_color(0, 0, 0, 255, 255);    // white
}

[Xeroxxx]

I can confirm this happens for me too. LCD Display stays empty, LED cycles through green, red, off etc.

@Tannoo
Where I've to add this?

[Tannoo]

In neopixel.cpp.

[Tannoo]

It's not an addition... it's a change.

In the funtion setup_neopixel(), change all the delay(2000)'s to safe_delay(2000).

[Tannoo]

That will insure all background processes keep processing.

[Xeroxxx]

Hmm...and this file can be found where?

Can't find the function in Marlin or NeoPixel Library.

[Tannoo]

Marlin/src/feature/leds/neopixel.cpp

[Xeroxxx]

Ahh okay this is 2.x. However search function of github does not work properly and I haven't been able to find the code.

Code for 1.1.x can be found in Marlin_main.cpp

[Xeroxxx]

Works great, are you going to push this to the repo? If you don't mind I can do this.

[Tannoo]

I can't push. I'm not that important. Lol

[Tannoo]

I can nudge.

[Xeroxxx]

gj :) 👍

@Tannoo
ssafe_delay?

Isn't it "safe_delay"?

[Tannoo]

Did I have a type-o?

[Xeroxxx]

I guess so.

[SCiunczyk]

Issue could be closed I think. There are PR fixing this.