Marlin: f4246dc Broke my Z axis

Created on 28 Jun 2017  路  18Comments  路  Source: MarlinFirmware/Marlin

Downloaded the latest bugfix (after commit f4246dc) and my z axis homes OK but completely ignores G1
commands (X & Y fine). Reverted to the previous days code and all is fine again (only preserved Configuration.h/Configuration_adv.h)

Solved

All 18 comments

I'm having the same issue. Glad it's not just me...

Looks likes disabling FASTER_GCODE_PARSER in _Configuration_adv.h_ works as a temporary fix for this issue.

same here

Mine is still broken so I went back to Sprinter No remote but at least it works.

I'm not sure why, but it's not parsing Z correctly:

Got letter G at index 5 (has_num)
Set bit 7 of index 0 | param = 0x0006
Got letter Z at index 8 (has_num)
Command: G800 G0 Z10 (G800)
 args: "G "

Code 'G':
    float: 0.00
     long: 0
    ulong: 0
   millis: 0
   sec-ms: 0
      int: 0
   ushort: 0
     byte: 0
     bool: 0
   linear: 0.00
  celsius: 0.00

See @Bob-the-Kuhn's response below...

Looks likes disabling FASTER_GCODE_PARSER in Configuration_adv.h works as a temporary fix for this issue.

Although, I had to do this also to get Repetier to work.

I can send G1 Z10 and it work fine.. even through Repetier... But, I click the button in Repetier to do the same thing, nothing moves.

@Tannoo - see if changing only line 107 in gcode.h gets Z movement.
Is: #define LETTER_OFF(N) ((N) - 'A' + 1)
To: #define LETTER_OFF(N) ((N) - 'A')

I believe the root cause is the array param has indices 0-25 but LETTER_OFF(N) returns 1-26.

That works, thank you.

It now works as expected with and without FASTER_GCODE_PARSER and with or without Repetier.

And the debug is okay again.. lol

OK - I'll push a PR immediately.

I've just merged PR #7183 to fix this.

seems to work now

@jimovonz does it also work for you now?

if so maybe consider closing the issue?

@thinkyhead i think we can close this one

I can't reproduce, G1 moves are OK

@Bob-the-Kuhn can you close it or has @thinkyhead to do that?

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Matts-Hub picture Matts-Hub  路  3Comments

manianac picture manianac  路  4Comments

otisczech picture otisczech  路  3Comments

Kaibob2 picture Kaibob2  路  4Comments

esenapaj picture esenapaj  路  3Comments