Marlin: Little Marlin 1.1.1 bug

[edautz]

Upgrade my CTC Prusa I3 from 1.1.0-RC8 to 1.1.1.

I noticed a little bug. When using the manual bed level feature, after the start of this feature through the display menu, the text on my display vanished, after turning the rotary encoder the text appears. Same for the first calibration point. This bug was not present in 1.1.0-RC8.

I using a (GT)2560 rev A clone control board with a Amtel 1280 AVR and LCD2004 Reprap discount controller with rotary encoder.

[thinkyhead]

The LCD code has gotten a tweak here and there. I'll look into this some time today.

[Maglin]

I've seen the same behavior. I never mentioned it though. Using a Delta and UBL.

[thinkyhead]

When using the manual bed level feature…

@edautz
MESH_BED_LEVELING or PROBE_MANUALLY?

[edautz]

@thinkyhead.

It is manual mesh bed leveling. I noticed sometimes after I start print from SD, after heating and homeing, printing starts and the text on the display also vanishes. Turn the encoder also displays the text again.

[thinkyhead]

Are you saying that the Status Screen disappears also?

[Roxy-3D]

I noticed a little bug. When using the manual bed level feature, after the start of this feature through the display menu, the text on my display vanished, after turning the rotary encoder the text appears.

This sounds similar to this: https://github.com/MarlinFirmware/Marlin/pull/6822#pullrequestreview-39521334

That is why I added the

     lcdDrawUpdate = LCDVIEW_REDRAW_NOW;

[thinkyhead]

Hmm… well that indicates a bug that we're just hacking around. I'll re-examine the display logic some more. Is this the graphical or character display, or both?

Thing is, we must use LCDVIEW_KEEP_REDRAWING because it works on both.

#if ENABLED(DOGLCD)
  bool drawing_screen = false;
  #define LCDVIEW_KEEP_REDRAWING LCDVIEW_CALL_REDRAW_NEXT
#else
  #define LCDVIEW_KEEP_REDRAWING LCDVIEW_REDRAW_NOW
#endif

If you're seeing the issue on one type of display but not the other, that would point to the use of LCDVIEW_CALL_REDRAW_NEXT or LCDVIEW_REDRAW_NOW instead of LCDVIEW_KEEP_REDRAWING.

[thinkyhead]

See if #6830 heralds a return to normalcy.

[Roxy-3D]

I saw the problem on a Graphical LCD Display. I don't know that I've seen it on a 20x4 LCD Panel.

[thinkyhead]

Graphical display would be the one that manifests the issue, if it is related to the choice of LCDVIEW flag. The character display would not.

[edautz]

The screen is going complete blank, if this occurs with beginning of the print, the status screen is going complete blank. I use a lcd 20x4 char display.

[Maglin]

I experience the same thing using a 20x4 GLCD. On a AnyCubic TriGorilla controller. I'm using the RAMPS 1.4 define for the MB. The stock FW was using MB 33 which I think is RAMPS1.3. Is there even a difference? Could this be the cause?

[Tannoo]

I see this now (when editing UBL mesh points) after running the code from this morning.

[renfrobr]

Same here using a 20x4 LCD. Screen blanks all over the place, any menu really. Touching the rotary encoder brings it back only to go blank again in the next screen/selection.

[Roxy-3D]

So the screen blanking problem is happening on both Graphical and 20x4 displays now???

[renfrobr]

Here we go ...

[ghost]

I made a video about this bug. Look the issue: #6856

[gtavo]

I have the same problem, when trying to level the bed, the text vanishes, I have a REPRAP_DISCOUNT_SMART_CONTROLLER with 20x4

[emartinez167]

This is now fixed with the latest patches.

On 25 May 2017, 23:05 +0800, Roxy-3D [e-mail], wrote:

So the problem is happening on both Graphical and 20x4 displays now???
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[renfrobr]

I can verify, it's fixed on my end

[edautz]

Marlin upgraded to 1.1.3. Problem gone.