Marlin: Display lines Error

Created on 10 Nov 2016 · 55Comments · Source: MarlinFirmware/Marlin

I have modified ultralcd.cpp to switch the LED case lights on/off:

 static void lcd_main_menu() {
    START_MENU();
    MENU_BACK(MSG_WATCH);
    MENU_ITEM(gcode, MSG_LIGHTS_OFF, PSTR("M42 P11 S0"));            //Lights Off
    MENU_ITEM(gcode, MSG_LIGHTS_ON, PSTR("M42 P11 S255"));           //Lights On LED Strip on PIN D11
    #if ENABLED(BLTOUCH)
      if (!endstops.z_probe_enabled && TEST_BLTOUCH())
        MENU_ITEM(gcode, MSG_BLTOUCH_RESET, PSTR("M280 P" STRINGIFY(Z_ENDSTOP_SERVO_NR) " S" STRINGIFY(BLTOUCH_RESET)));
    #endif

    if (planner.movesplanned() || IS_SD_PRINTING) {
      MENU_ITEM(submenu, MSG_TUNE, lcd_tune_menu);
    }
    else {
      MENU_ITEM(submenu, MSG_PREPARE, lcd_prepare_menu);
      #if ENABLED(DELTA_CALIBRATION_MENU)
        MENU_ITEM(submenu, MSG_DELTA_CALIBRATE, lcd_delta_calibrate_menu);
      #endif
    }
    MENU_ITEM(submenu, MSG_CONTROL, lcd_control_menu);

    #if ENABLED(SDSUPPORT)
      if (card.cardOK) {
        if (card.isFileOpen()) {
          if (card.sdprinting)
            MENU_ITEM(function, MSG_PAUSE_PRINT, lcd_sdcard_pause);
          else
            MENU_ITEM(function, MSG_RESUME_PRINT, lcd_sdcard_resume);
          MENU_ITEM(function, MSG_STOP_PRINT, lcd_sdcard_stop);
        }
        else {
          MENU_ITEM(submenu, MSG_CARD_MENU, lcd_sdcard_menu);
          #if !PIN_EXISTS(SD_DETECT)
            MENU_ITEM(gcode, MSG_CNG_SDCARD, PSTR("M21"));  // SD-card changed by user
          #endif
        }
      }
      else {
        MENU_ITEM(submenu, MSG_NO_CARD, lcd_sdcard_menu);
        #if !PIN_EXISTS(SD_DETECT)
          MENU_ITEM(gcode, MSG_INIT_SDCARD, PSTR("M21")); // Manually initialize the SD-card via user interface
        #endif
      }
    #endif //SDSUPPORT

    #if ENABLED(LCD_INFO_MENU)
      MENU_ITEM(submenu, MSG_INFO_MENU, lcd_info_menu);
    #endif

    END_MENU();
  }

This makes the main menu look like this

on1

When i click "Licht an" the display behaves as expected.
When i click "Licht aus" the display becomes faulty and stays like this until i turn the encoder knob.

off2

Clicking on any other entry behaves normal.

Confirmed ! Solved

Source

Kaibob2

Most helpful comment

Funny how the bug jumped out at me and was obvious once I had enough sleep. 😁

thinkyhead on 30 Nov 2016

😄2

All 55 comments

Can confirm this happens on several items in the LCD menu in vanilla Marlin as well.

petrzjunior on 10 Nov 2016

Which version of Marlin are you running?

landodragon141 on 12 Nov 2016

RCBugfix as of 10.11.2016
I can also confirm that this happens on other items:
20161111_185301_resized

Kaibob2 on 12 Nov 2016

@thinkyhead Any idea on this?

Kaibob2 on 12 Nov 2016

@Kaibob2 @petrzjunior Interesting behavior. Unfortunately I have no equipment to debug on, so I'm afraid someone else will have to do the legwork to figure this out.

Note: Instead of M42, in RCBugFix you may now define CASE_LIGHT_PIN in Configuration_adv.h and use M355 S1 (on) and M355 S0.

thinkyhead on 16 Nov 2016

@thinkyhead I already found this case light lines. Didn't know it was accesible via M355. Maybe this should be mentioned in the comment.
// Define a pin to turn case light on/off
to

// Define a pin to turn case light on/off
//Use M355 S1 to switch on or M355 S0 to switch off

By having this case light function, wouldn't it be great to have a menu entry to toggle the light? The way i did it is due to limited coding skills. A "Toggle case light" would be much more convenient than one ON and one OFF line.

Kaibob2 on 16 Nov 2016

👍1

@thinkyhead Quick observation report: bug appears when you click on MENU_ITEM of type gcode like Auto home, Steppers release or Kaibob's LED controls. If the clicked item is on the first line, then the second line and half of the third one disappears. If you click on the second line, then only the third line's top half is blank. If the item is on third or lower line, nothing strange happens.

petrzjunior on 16 Nov 2016

Actually this happens to me as well. Somethings I know for sure trigger it are: refresh sd card, on off for volumetric extrusion. I haven't really though about it before now. I'll let you guys know if I notice anything else.

landodragon141 on 17 Nov 2016

I wish I could explain it. Invoking a gcode command through the menu doesn't do anything special. The screen simply gets redrawn in response to the click. I'm guessing this only affects graphical displays.

thinkyhead on 17 Nov 2016

@petrzjunior Good observation! It's exactly the same here (like expected). I always wanted to dig into finding a red line to when exactly it happens, but there where always "more important" things to fix at the moment.

Kaibob2 on 17 Nov 2016

I see that the handling of LCDVIEW_CLEAR_CALL_REDRAW needs to be tweaked for parity with the updated click handling. Perhaps that will help.

thinkyhead on 17 Nov 2016

Try this: in ultralcd.cpp after the line that calls lcd_quick_feedback() add next_lcd_update_ms = millis();.

When it comes down to it, most commands don't need to redraw the screen, but only those where a value needs to be redrawn or the page changes, so maybe that should not be set on every lcd_quick_feedback.

thinkyhead on 17 Nov 2016

next_lcd_update_ms = millis();
Seams logical, as a turn of the encoder refreshes the screen and this fixes the blanked lines too.
I will test it this evening.

Kaibob2 on 17 Nov 2016

👍1

Doesn't seem to do anything, still the same.