Marlin: '>' disapear when going to far in menu

Created on 29 Jul 2016  路  7Comments  路  Source: MarlinFirmware/Marlin

It's not really important, but sometimes I'm looking for the '>' which disapears when I navigate in menu with coder and when I go too far.
I don't know if it's the good location to report this "issue".

sorry for my English

Spilz

Confirmed !

Most helpful comment

I just test it, it seems ok.
I didn't try all menu

Thanks for your help

All 7 comments

Thank you @spilz87 for reporting the issue, we're looking into it.

Probably a simple bug. I'll mess with my LCD tonight and come up with a patch.

@spilz87 I believe this might fix it for you. Add the following new line in ultralcd.cpp:

// Scroll through menu items, scrolling as-needed to stay in view
#define END_MENU() \
  } \
  if (encoderLine >= _thisItemNr) { \
    encoderLine = _thisItemNr - 1; \
    encoderPosition = encoderLine * (ENCODER_STEPS_PER_MENU_ITEM); \
+   lcdDrawUpdate = LCDVIEW_CALL_REDRAW_NEXT; \
  } \
  if (encoderLine >= encoderTopLine + LCD_HEIGHT) { \
    encoderTopLine = encoderLine - (LCD_HEIGHT - 1); \
    lcdDrawUpdate = LCDVIEW_CALL_REDRAW_NEXT; \
  } \
  UNUSED(_skipStatic)

Thanks,
I will test it when I come back home, end of week

@spilz87 did you test this?

Closed by #4512.
Pleas reopen this issue if the problem still persists.

I just test it, it seems ok.
I didn't try all menu

Thanks for your help

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jerryerry picture jerryerry  路  4Comments

Bobsta6 picture Bobsta6  路  3Comments

ceturan picture ceturan  路  4Comments

otisczech picture otisczech  路  3Comments

Ciev picture Ciev  路  3Comments