Markup: headings not rendering anymore

[davidmoten]

In the last couple of days github markdown rendering has stopped rendering headings without delimiting spaces:

This used to render fine:

##Header

but now has to be:

## Header

Was this a deliberate move? You'd have to consider it a major breaking change!

[shawnajean]

Hi David! This is related to our move to CommonMark for markdown rendering:

https://github.com/blog/2333-a-formal-spec-for-github-flavored-markdown

CommonMark requires that there be a space between the # characters and the title. We do not consider this a bug, so I'm going to close this out. Please reach out to our support team if you need more help!

[davidmoten]

Righto thank you

On Fri, 17 Mar 2017, 00:44 Shawna Jean [e-mail] wrote:

Closed #1013 https://github.com/github/markup/issues/1013.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/github/markup/issues/1013#event-1002735783, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATa6xG7at1ech_fYcZ1sH3Hmj49icCCks5rmTy9gaJpZM4MfAFZ
.

[jaan]

Found this issue on most of my readme pages. I wish github had proactively conveyed this to users about their broken pages and a need for fix.

[devios1]

This completely defeats the purpose of Markdown. What possible reason could there be for imposing this absurd restriction?

[lee-dohm]

As was stated in this other issue, the markup gem doesn't control GitHub's Markdown rendering. Since this is off-topic for this repo, I'm going to lock this issue.

If you have questions about GitHub's Markdown rendering, please reach out to the support team.