Marked: em and strong (〜)

Created on 4 Dec 2020 · 6Comments · Source: markedjs/marked

Thanks for the great project.

When em and strong are used together, there appears to be a difference in the analysis results.
At the beginning of a line, em and strong are parsed properly, but in a sentence, they are not.
Is this as expected? We would be happy to confirm it when you have time.

The following link is for your reference.

https://marked.js.org/demo/?text=AAAAAAAAAAAAAA%0A%0AAAAAAAAAAAAAAA%0A%0AAAAAAAAAAAAAAA%0A&options=%7B%0A%20%22baseUrl%22%3A%20null%2C%0A%20%22breaks%22%3A%20false%2C%0A%20%22gfm%22%3A%20true%2C%0A%20%22headerIds%22%3A%20true%2C%0A%20%22headerPrefix%22%3A%20%22%22%2C%0A%20%22highlight%22%3A%20null%2C%0A%20%22langPrefix%22%3A%20%22language-%22%2C%0A%20%22mangle%22%3A%20true%2C%0A%20%22pedantic%22%3A%20false%2C%0A%20%22sanitize%22%3A%20false%2C%0A%20%22sanitizer%22%3A%20null%2C%0A%20%22silent%22%3A%20false%2C%0A%20%22smartLists%22%3A%20false%2C%0A%20%22smartypants%22%3A%20false%2C%0A%20%22tokenizer%22%3A%20null%2C%0A%20%22walkTokens%22%3A%20null%2C%0A%20%22xhtml%22%3A%20false%0A%7D&version=master

L1 - broken inline elements released

Source

plotpoi

Most helpful comment

Got a working solution. Just need to clean it up a bit and I'll post a PR.

calculuschild on 6 Dec 2020

🎉2

All 6 comments

looks like this was broken in #1686 it works in v1.1.0

CommonMark demo
Marked v1.1.0 demo
Marked v1.1.1 demo

UziTech on 4 Dec 2020

👍2

@UziTech Looks like this is covered by GFM Example 425 which isn't in our test specs. It looks like the GFM spec has been updated somewhat since the original test cases were made (many of the example numbers no longer match). Do we also want to update those tests now to help avoid more regressions like this?

calculuschild on 4 Dec 2020

@calculuschild this is covered by CommonMark example 415

It was marked as shouldFail because v1.1.0 had strong and em tags switched so it technically wasn't passing in v1.1.0 but the result in the browser was the same.

UziTech on 4 Dec 2020

Alright. I'm looking into this.

calculuschild on 4 Dec 2020

Got a working solution. Just need to clean it up a bit and I'll post a PR.

calculuschild on 6 Dec 2020

🎉2

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: