Mapsui: Change license to MIT

Created on 30 Jan 2018  Â·  26Comments  Â·  Source: Mapsui/Mapsui

At some point I would like to to change to license of this project to MIT. For this some things need to be done.

  • Rewrite parts of the code. I think it is not that much.
  • Remove parts of the code that is inherited from other projects. I think I can find alternatives.
  • Get current contributors to agree to re-license the code.

For this last one I would like to ask the contributors to sign the CLA. The CLA can found here

So if you would like to help us please sign. If you don't, no problem at all, we are still thankful for your contributions :)

  • @charlenni
  • @JoeCooper
  • @drwatson1
  • @Skymirrh
  • @grudolf
  • @kwesolowski
  • @TFleury
  • @tebben
  • @smremde
  • @radderz
  • @gklamm
  • @scottdewald
  • @bertt
enhancement

Most helpful comment

I searched the Mapsui repository to see what needs to be done.

  • Currently there are 54 files with the 'This file is part of SharpMap' header.
  • 10 of those are originally mine, with a Paul den Dulk copyright notice, also I can remember creating them. 44 left.
  • 1 is by Scott Dewald who signed the CLA. 43 left
  • 22 are in the Mapsui.Geometries project. They will be replaced by NTS. There will probably be e few things that will not come from NTS, we have to create our own. For example, Point. I think we should have our own, I want to keep the dependency on NTS somewhat Isolated. It should be possible to use TileLayer without a NTS dependency. 21 left.

For those 21 files I will get the committers from the period before our fork and try to reach them or remove their code.

All 26 comments

I'd be happy to sign it but it will have to be next week. I am out of town
in vacation right now.

Scott Dewald

On Jan 30, 2018 1:51 PM, "Paul den Dulk" notifications@github.com wrote:

At some point I would like to to change to license of this project to MIT.
For this some things need to be done.

  • Rewrite parts of the code. I think it is not that much.
  • Remove parts of the code that is inherited from other projects. I
    think I can find alternatives.
  • Get current contributors to agree to re-license the code.

For this last one I would like to ask the contributors to sign the CLA.
The CLA can found here https://cla-assistant.io/pauldendulk/Mapsui

So if you would like to help us please sign. If you don't, no problem at
all, we are still thankful for your contributions :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pauldendulk/Mapsui/issues/301, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABxE0dKWjphx1DhU8p4MSutmyw3NPy6pks5tP4DPgaJpZM4Ry_dD
.

Do you know how much of the code doesn't come from other MIT licenced code?

@scottdewald No problem. It could take months before it is changed.

@radderz It originates from SharpMap which is LGPL but a lot has been rewritten.

SharpMap

  • The geometries are SharpMap and need to be replaced. Perhaps with NTS.
  • The symbols are SharpMap and need to be rewritten. I was thinking about something simple initially
  • The basics of the Layers and Providers originates from SharpMap but the current form is Mostly Mapsui and many specific providers and layers are Mapsui. I will rewrite it. Perhaps some providers could stay as LGPL in their own repository.

Mapsui

  • The fetcher and all async fetching is Mapsui
  • Everything related to tiling is Mapsui
  • The ArcGISDynamicLayer is Mapsui
  • The Viewport is Mapsui
  • All MapControls are Mapsui (SharpMap had a WinForms MapControl).

Signed.

Signed.

Signed

Done!

Signed.

Me too.

Wow, so many responses so soon. Thanks everybody!

Signed

Done 😉

Signed

Signed

On Wed, Jan 31, 2018 at 8:52 PM, drwatson1 notifications@github.com wrote:

Signed

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pauldendulk/Mapsui/issues/301#issuecomment-362142192,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABxE0fr953U_uQrTFm0U8adTIF8Y5W7Oks5tQSbXgaJpZM4Ry_dD
.

Hi Everyone, and thank you for trying to change this library to the MIT license :)
Is there any way to guess when we'll be able to use the library for commercial purposes?
The small company I'm working at this is very critical. Until recently all apps were Windows phone apps, now you can imagine the issues that arise now that M$ killed Windows Mobile...
Thanks for any reply,
Cheers George

@groege Where is your problem with using LGPL?

Well maybe I misunderstand, but when building an App Package (iOS, Android,
UWP), the dll becomes part of that package, thus we'd have to publish our
code right? Or can we still use the lib for commercial use, without
publishing the code?

On Tue, Jun 19, 2018 at 4:28 PM, charlenni notifications@github.com wrote:

@groege https://github.com/groege Where is your problem with using LGPL?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Mapsui/Mapsui/issues/301#issuecomment-398419259, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOoWRpzh3dCzcX8cS4sk_N07PxjlfyqIks5t-QqhgaJpZM4Ry_dD
.

Yes, that is the theory. In practice I don't think anyone will ask you to publish your code but if you want to play it save you have to wait for MIT. Unfortunately I can not promise anything with respect to the progress. The plan is to do some further refactoring on 2.0 and after it's release we can start to think about replacing Mapsui.Geometries with NTS and then MIT is in sight.

Ok, thank you!
The thing is we kind of have to play it safe since our company has been
sued before because of moronic reasons...
That's why I thought we might be able to start developing with mapsui and
hopefully the lib would be MIT before we release it.
So I guess we'll start with the non map features first and hopefully we'll
be able to switch to mapsui by then (or at least there will be progress
towards it so that it's reasonable to start implementing the map features
by then) :)
Cheers!

On Tue, Jun 19, 2018 at 10:37 PM, Paul den Dulk notifications@github.com
wrote:

Yes, that is the theory. In practice I don't think anyone will ask you to
publish your code but if you want to play it save you have to wait for MIT.
Unfortunately I can not promise anything with respect to the progress. The
plan is to do some further refactoring on 2.0 and after it's release we can
start to think about replacing Mapsui.Geometries with NTS and then MIT is
in sight.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Mapsui/Mapsui/issues/301#issuecomment-398536956, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOoWRj3XRl_dvQzJ6YVCf0I1C5dC-BrMks5t-WD3gaJpZM4Ry_dD
.

NTS uses GeoAPI and GeoAPI is under LGPL. So I see not, how using NTS makes things better.

Here is a good answer to this theme.

NTS was ported from JTS. JTS has changed it's license. NTS and GeoAPI will follow. At least that was my assumption but I read here GeoAPI.CoordinateSystems will stay LGPL https://github.com/NetTopologySuite/NetTopologySuite/issues/196#issuecomment-384953899
That is a problem.

Just in good order, I signed the CLA wrt to my parts of SharpMap, and allow all non-derived works in SharpMap that I built to be re-licensed under MIT (Just note that there might be pieces of SharpMap that's derived from other works, but those parts should be called out in the individual files)

With the original SharpMap author Morten also signing the CLA it becomes feasible to make the move to MIT. So I am looking for what else needs to be done.

We forked SharpMap on 2012-01-24.
image

The SharpMap repository contains history from 2006-09-12. That is quite a while back. It may miss some history before that, but I assume that is Morten's. The SharpMap copyright notices are from 2005 and 2006.
image

This makes it possible to track down possible other contributors.

I searched the Mapsui repository to see what needs to be done.

  • Currently there are 54 files with the 'This file is part of SharpMap' header.
  • 10 of those are originally mine, with a Paul den Dulk copyright notice, also I can remember creating them. 44 left.
  • 1 is by Scott Dewald who signed the CLA. 43 left
  • 22 are in the Mapsui.Geometries project. They will be replaced by NTS. There will probably be e few things that will not come from NTS, we have to create our own. For example, Point. I think we should have our own, I want to keep the dependency on NTS somewhat Isolated. It should be possible to use TileLayer without a NTS dependency. 21 left.

For those 21 files I will get the committers from the period before our fork and try to reach them or remove their code.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kisslori picture kisslori  Â·  8Comments

felipechavez picture felipechavez  Â·  4Comments

Wil69 picture Wil69  Â·  5Comments

ricardoboss picture ricardoboss  Â·  5Comments

othmaniav picture othmaniav  Â·  7Comments