Mapbox-navigation-android: Can I drop Jetifier?

[Guardiola31337]

Run into https://twitter.com/inyaki_mwc/status/1288154455775391744 and thought that would be a great idea to take https://github.com/plnice/can-i-drop-jetifier for a quick spin and if possible remove https://github.com/mapbox/mapbox-navigation-android/blob/70601507f0fc869fe425f54413c5eed0898a63cb/gradle.properties#L28 in order to scratch some build time.

> Task :canIDropJetifier
========================================
Project examples
========================================

Cannot drop Jetifier due to following external dependencies:

* com.mapbox.navigation:libnavigation-ui:1.0.0-SNAPSHOT

* com.google.android.gms:play-services-location:16.0.0

========================================
Project libdirections-hybrid
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libdirections-offboard
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libdirections-onboard
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libnavigation-base
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libnavigation-core
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libnavigation-metrics
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libnavigation-ui
========================================

Cannot drop Jetifier due to following external dependencies:

* com.squareup.picasso:picasso:2.71828

* org.robolectric:robolectric:4.3.1

========================================
Project libnavigation-util
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libnavigator
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libtesting-ui
========================================

No dependencies on old artifacts! Safe to drop Jetifier.

========================================
Project libtesting-utils
========================================

No dependencies on old artifacts! Safe to drop Jetifier.

========================================
Project libtrip-notification
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

After updating com.google.android.gms:play-services-location to 17.0.0 this is the current output 👀

> Task :canIDropJetifier
========================================
Project examples
========================================

Cannot drop Jetifier due to following external dependencies:

* com.mapbox.navigation:libnavigation-ui:1.0.0-SNAPSHOT

========================================
Project libdirections-hybrid
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libdirections-offboard
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libdirections-onboard
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libnavigation-base
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libnavigation-core
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libnavigation-metrics
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libnavigation-ui
========================================

Cannot drop Jetifier due to following external dependencies:

* com.squareup.picasso:picasso:2.71828

* org.robolectric:robolectric:4.3.1

========================================
Project libnavigation-util
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libnavigator
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

========================================
Project libtesting-ui
========================================

No dependencies on old artifacts! Safe to drop Jetifier.

========================================
Project libtesting-utils
========================================

No dependencies on old artifacts! Safe to drop Jetifier.

========================================
Project libtrip-notification
========================================

Cannot drop Jetifier due to following external dependencies:

* org.robolectric:robolectric:4.3.1

* com.squareup.picasso:picasso:2.71828

We should think about what we're going to do with Picasso and OkHttp 👀 https://github.com/mapbox/mapbox-navigation-android/pull/2762 and https://github.com/mapbox/mapbox-navigation-android/issues/2790

* org.robolectric:robolectric:4.3.1

This is https://github.com/robolectric/robolectric/issues/5523 which looks like it wasn't released, yet.

cc @mapbox/android

[carstenhag]

Heh, I have also seen that tweet and tried it on our project -- there were many other libs failing (appauth for example) but mapbox had the most dependencies. Glad you are looking into this!

[Guardiola31337]

@carstenhag this great post by @ditn may be of your interest - especially What if I can’t fix it? section

cc @rafagf

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[carstenhag]

Robolectric has been released on 24th of August. Can, you please try it out and see whether it works fine? :D

[carstenhag]

Updating Robolectric worked fine for me fyi, I don't see any jetifier usage anymore on my project.