Mapbox-gl-native: Add telemetry performance event

Created on 24 Jan 2019 · 8Comments · Source: mapbox/mapbox-gl-native

This issue tracks integration of https://github.com/mapbox/mapbox-events-android/pull/318 in the maps sdk. @chloekraw @zugaldia, which performance events should we track?

Android telemetry

Source

tobrun

Most helpful comment

which performance events should we track?

I'd like to start with two: tile loading latency and tile downloading failure. However, I'd like to keep the implementation flexible enough to support any performance event we decide to add in the future.

In terms of implementation, we'd like to take advantage of the MapboxTelemetry.push() API. To do that we'd need to do the following things:

Expose this API in TelemetryImpl and TelemetryDefinition for events of type Type.NO_OP where event.name == performance.trace.
Implement a generic PerformanceEvent that extends Event (note that we do not need to implement the logic for Parcelable because that is being deprecated).
Test the event data is coming in by collecting both metrics mentioned above in the test app or demo app.

@osana @langsmith Do you have the bandwidth to team up on this one?

cc: @andrlee in case you want to provide any additional guidance.

zugaldia on 24 Jan 2019

👍2

All 8 comments

which performance events should we track?

In terms of implementation, we'd like to take advantage of the MapboxTelemetry.push() API. To do that we'd need to do the following things:

Expose this API in TelemetryImpl and TelemetryDefinition for events of type Type.NO_OP where event.name == performance.trace.
Implement a generic PerformanceEvent that extends Event (note that we do not need to implement the logic for Parcelable because that is being deprecated).
Test the event data is coming in by collecting both metrics mentioned above in the test app or demo app.

@osana @langsmith Do you have the bandwidth to team up on this one?

cc: @andrlee in case you want to provide any additional guidance.

zugaldia on 24 Jan 2019

👍2

Here is a first take on adding generic PerformanceEvent to mapbox-events-android
https://github.com/mapbox/mapbox-events-android/pull/332

osana on 24 Jan 2019

@osana and I chatted this morning about this. As she linked above, creating a PerformanceEvent in the telem sdk is the first step. Then we'll tackle the TelemetryImpl/ TelemetryDefinition implementation and then finish up with testing.

langsmith on 24 Jan 2019

Building gl-native in my Android Studio is an absolute dumpster fire right now, so it's been impossible for me to look through the Maps SDK to work on things myself. Working on fixing things....

langsmith on 24 Jan 2019

folks, it looks like there's a confusion about plans around perf event. we've made changes on our end to enable event creation outside of telem sdk and the guideline going forward would be to keep events outside of sdk. this will drastically accelerate our development cycles. does that make sense? could you please sync with @zugaldia regarding implementation details of the event?