Mapbox-gl-native: IOS: Offline pack is not working properly on next day when iPad is in offline.

[ThiyagarajanShivSankaran]

Platform: IOS
Mapbox SDK version: 3.6.0

Steps to trigger behavior

1. Download all the offline packs.
2. Leave the device offline until tomorrow, or change the date time in device to tomorrow.
3. Then the offline pack is not loading properly.

Expected behavior

1. The offline pack's should work even after the device is in offline for more than 3 to 4 days.

Actual behavior

1. But it's not working every time we need to come online.

We have client's who will work only in offline for more than 2 days. In that case the offline packs should work , but it's not working. I think the tiles are expiring every day.

[ThiyagarajanShivSankaran]

Please download the video file from dropbox for further reference of this issue,

https://www.dropbox.com/s/sdfs2y05ivrz9q3/mapbox%20offline%20pack%20issue.mov?dl=0

But, I have checked the same scenario using the older SDK v3.5.4, it's working there.

[kkaefer]

@ThiyagarajanShivSankaran thanks for reporting this bug

[kkaefer]

@ThiyagarajanShivSankaran it's hard to see this from the video; are you using raster tiles or vector tiles?

[ThiyagarajanShivSankaran]

@kkaefer we are using vector tiles. Sorry for the video clarity can you download and check. Thanks.

[arnekaiser]

This looks like https://github.com/mapbox/mapbox-gl-native/issues/9211

I think the expires timestamps in the database are expired after some days.

[andrewljohnson]

I think we fixed the bulk of this problem with a simple change, in src/mbgl/tile/tile_loader_impl.hpp

template <typename T>
  void TileLoader<T>::loadedData(const Response& res) {
      if (res.error && res.error->reason != Response::Error::Reason::NotFound) {
 -        tile.setError(std::make_exception_ptr(std::runtime_error(res.error->message)));
 +        if (!(tile.isComplete() && tile.isRenderable())) {
 +          tile.setError(std::make_exception_ptr(std::runtime_error(res.error->message)));
 +        }
      } else if (res.notModified) {
          resource.priorExpires = res.expires;
          // Do not notify the tile; when we get this message, it already has the current

[ThiyagarajanShivSankaran]

Can I know what is the status of this issue. We need this to be fixed immediately. Thanks.

[ThiyagarajanShivSankaran]

@kkaefer @friedbunny @boundsj Status please ???

[friedbunny]

@ThiyagarajanShivSankaran There’s been no change in the status of this issue — when someone has the opportunity to investigate further, they will post an update here. In the meantime, any additional information (or testing of proposed fixes) is much appreciated.

[arethasamuel]

@andrewljohnson is this fix in the latest release of mapbox sdk? 3.6.2? we will test this and get back to you

[andrewljohnson]

@arethasamuel not AFAIK

[arethasamuel]

@andrewljohnson @kkaefer @friedbunny @boundsj

this issue still exists in mapbox 3.6.2

1) Turn on wifi --> Download all the offline packs.
2) change the date time in device to tomorrow
3) Open the device in airplane mode --> open the app again and the tiles are no longer showing

So i opened up the cache.db sqlite database and found out that the table: tiles has a column called expires and the value of the expires column has a date 12 hours After the offline pack was installed.

Is there a way to increase this time? (like at least by a year or something?)

[ThiyagarajanShivSankaran]

Hi @friedbunny yeah the above fix is working.

[jmkiley]

@kkaefer do you think that the fix @andrewljohnson proposed in https://github.com/mapbox/mapbox-gl-native/issues/9705#issuecomment-322931885 should be pulled into the SDK?

[kkaefer]

There are several underlying issues:

• We're treating a 404 response/not found as a valid response meaning "there is no data here" instead of using a correct HTTP 204 No content response. E.g. here: https://github.com/mapbox/mapbox-gl-native/blob/366a69785a2fffd0713897f53647cf18b7a0c645/platform/default/http_file_source.cpp#L378
• When we have a tile successfully parsed/loaded (e.g. an expired tile from cache), subsequent attempts to refresh the tile fail, and overwrite the existing successfully parsed tile with empty data (this is what https://github.com/mapbox/mapbox-gl-native/issues/9705#issuecomment-322931885 attempts to fix, although this fix doesn't work in situations where we're still parsing data (so the tile isn't renderable yet), then receive a revalidation error)

I attempted a refactor of our tile state system in https://github.com/mapbox/mapbox-gl-native/tree/make-stale-resources-renderable, but it's incomplete.

[friedbunny]

This should be fixed by https://github.com/mapbox/mapbox-gl-native/pull/10012 and 3.6.4, which will be available imminently.