Mapbox-gl-native: Blacklist GL program binary caching Adreno GPUs

[tobrun]

We are noticing some render artefacts on master:

Since labels, borders etc aren't showing at the appropriate zoom levels, I'm hunching that this will be related

Was tested on a Nexus 5 running Android 4.4. also reproducible on a Moto X running 5.1

[tobrun]

Got a reproducible scenario from a clean install:

First time the map renders correctly, second time the map doesn't anymore.

Going to git bisect this issue

[tobrun]

Bisected it to commit b5fed1172d77bac0ba122c73a9d30739a51e5028 from https://github.com/mapbox/mapbox-gl-native/pull/9373.
Reproducible on attribute-location from https://github.com/mapbox/mapbox-gl-native/pull/9433.

cc @lbud @jfirebaugh

[jfirebaugh]

This likely is an issue with program binary caching. It doesn't reproduce on the S4 I've been testing #9433 with, although it does support program binaries. Do we have a Nexus 5 or Moto X in our SF inventory?

[tobrun]

@danswick, I remember you having a Moto X? Would you be able to check the SF inventory?

[jfirebaugh]

@tobrun Is this still reproducible after the merge of #9433, which includes speculative fixes for binary caching?

[tobrun]

Still reproducible. @danswick were you able to find the Moto X?

[Guardiola31337]

@jfirebaugh still reproducible in a Moto X (2nd gen) running Android 5.0 and in a Nexus 5 running Android 6.0
cc/ @tobrun @danswick

[jfirebaugh]

Couldn't reproduce this on the Nexus 5 device in the SF office. We're going to order a dedicated Moto X test device for the SF office.

[edpop]

Still artefacts on Mapbox Demo 5.1.0-6, ASUS_T001.

[jfirebaugh]

While we're waiting for the device to be delivered -- @Guardiola31337, can you check if this happens on the release branch? b5fed1172d77bac0ba122c73a9d30739a51e5028 got cherry-picked to the release branch in eed89fcf9d099266aa793375ad63493e880f8a80 (as part of #9440), and the issue might have come with it.

[jfirebaugh]

@edpop, I think you're experiencing a different issue. This issue was not in the 5.1.0 release.

[Guardiola31337]

@jfirebaugh

can you check if this happens on the release branch?

I tried it on release-ios-v3.6.0-android-v5.1.0 branch and the same thing happens (both Nexus 5 and Moto X).

[edpop]

@jfirebaugh

I think you're experiencing a different issue. This issue was not in the 5.1.0 release.

But the issue is closed https://github.com/mapbox/mapbox-gl-native/issues/9184 as duplicate of closed https://github.com/mapbox/mapbox-gl-native/issues/8658. Maybe we should to reopen it?

[jfirebaugh]

9184 is a duplicate of #8658. #8658 is not a duplicate of this issue. #8658 is fixed for 5.2.0 and 5.1.1, but not 5.1.0.

[Adding to the confusion, Github is now going to _oh so helpfully_ report that I marked this as a duplicate of #8658 because I wrote "is a duplicate of #8658". THANKS GITHUB! (This is sarcasm. To reiterate: this is _not_ a duplicate of #8658 or vice versa.)]

[1ec5]

9184 is a đüṕłīçåťə of #8658. 😉

(More helpfully: the workaround for that keyword feature is to say “dupe”.)

[jfirebaugh]

Both Nexus 5 and Moto X use Adreno 3xx GPUs, so this is very likely https://bugs.chromium.org/p/chromium/issues/detail?id=510637.

[jfirebaugh]

Looks like we should blacklist program caching for all Adreno 3xx, 4xx, and 5xx GPUs: https://chromium.googlesource.com/chromium/src/gpu/+/master/config/gpu_driver_bug_list.json#2316