Mapbox-gl-native: Display SDK version in action sheet title

Created on 2 Oct 2016  Â·  6Comments  Â·  Source: mapbox/mapbox-gl-native

When the user taps the ℹ️ button in the corner of a map view, an action sheet appears with “Mapbox iOS SDK” in faint text in the title bar. Should this title indicate the SDK version? That would make it easier to diagnose issues in shipping applications, although it might be less aesthetically pleasing.

/cc @friedbunny

good first issue iOS

Most helpful comment

Whether or not discoverability is a major concern depends on what problem we’re trying to fix:

A. Mapbox developers diagnosing issues in apps we don’t control.

This is something I do somewhat frequently. Usually it means downloading the app through iTunes and spelunking the package. Discoverability: not important.

B. Developers figuring out which version of our SDK they’re using.

Developers should already know? Not sure that this is a common use case. Discoverability: somewhat important.

C. Users of apps reporting issues to us.

We don’t really want this happening — developers should be taking reports. Discoverability: not important.

All 6 comments

I’ve thought that this would be nice in the past, but I agree that it would be an unnecessary (if minor) aesthetic blemish in most cases.

It adds some complexity and overhead, but we could show the version if the attribution button is long pressed: https://github.com/mapbox/mapbox-gl-native/compare/fb-attribution-version-longpress

What about getting rid of the action sheet title and add a new first row with it instead, its action being to show the version?

one

Discoverable, no major change in current appearance, and easy to direct folks to.

We could also get fancier and advertise a bit to all developers and users if they happen to take a peek.

two

(Imaging this as an attributed, clickable link, or even a custom view, maybe showing multiple styles in a small four-square pattern?)

Whether or not discoverability is a major concern depends on what problem we’re trying to fix:

A. Mapbox developers diagnosing issues in apps we don’t control.

This is something I do somewhat frequently. Usually it means downloading the app through iTunes and spelunking the package. Discoverability: not important.

B. Developers figuring out which version of our SDK they’re using.

Developers should already know? Not sure that this is a common use case. Discoverability: somewhat important.

C. Users of apps reporting issues to us.

We don’t really want this happening — developers should be taking reports. Discoverability: not important.

Let’s consider extended silence here as a consensus “meh” vote against this feature.

Why did you reopen it? Was it A, B, or C?

it would be an unnecessary (if minor) aesthetic blemish in most cases

I can think of two ways to make the version aesthetically unobtrusive while remaining relatively convenient to Mapboxers trying to determine the map SDK version, at least compared to downloading an .ipa through iTunes 12.7:

  • Add a mapSdkVersion query parameter to the URL of the © Mapbox or Improve This Map action buttons.
  • Omit the version from the action sheet title the _first_ time the action sheet appears but include the version on each subsequent appearance.
Was this page helpful?
0 / 5 - 0 ratings