Mapbox-gl-native: Point annotations disappear at low zoomlevels
When you zoom out, point annotations disappears. Zooming back in restores them.
This was noticed on Android and was validated for iOS by @1ec5 with 3.3.0-alpha.3
tobrun
All 11 comments
These are GL point annotations, by the way.
1ec5
on 24 May 2016
Discussed internally with @tobrun @cammace today and this issue is a blocker for Android 4.1.0 FINAL release.
/cc @mapbox/mobile @jfirebaugh @kkaefer @tmpsantos @brunoabinader
bleege
on 24 May 2016
On it.
tmpsantos
on 27 May 2016
Found the commit that caused the regression: 4c62a5508cfa96755b37850051871320d79748fb
This is not only affecting annotations but also label density on low zoom levels:
/cc @ansis
tmpsantos
on 27 May 2016
Awesome. Thanks @tmpsantos @ansis!
bleege
on 27 May 2016
@tmpsantos Any idea what about 4c62a5508cfa96755b37850051871320d79748fb is causing the issue? (Let's assume that @ansis is focused on schoolwork.)
jfirebaugh
on 27 May 2016
@jfirebaugh I'm investigating but seems to me some integer overflow or float to integer conversion making it full transparent.
I was initially comparing to the code on JS trying to find anything wrong with the ported code but it seems fine.
tmpsantos
on 27 May 2016
@tmpsantos I just tested your fix in #5175 and can confirm that it solves this issue. Both markers (C and A) were visible at all zoom levels as well as when cycled on / off using the FAB (see screenshots below). I'm going to merge #5175 into master and then cherry pick the commit over to the release-android-v4.1.0 branch so that this fix gets into the nightly SNAPSHOTS as well as the final release. Thank you for fixing this!
bleege
on 27 May 2016
Cherry picked into Android's release-android-v4.1.0 branch.
bleege
on 27 May 2016
@bleege @tobrun
When can we expect new snapshot or beta-2 release with this fix?
mpuchala
on 30 May 2016
@mpuchala, thank you for reaching out. In normal circumstances you should be able to use the SNAPSHOT containing this fix. I just double checked the nightly builds and there seems to be a problem with building. I'm fixing this in https://github.com/mapbox/mapbox-gl-native/issues/5187.
tobrun
on 30 May 2016
Related issues
cmxyzx
路
3Comments
xrayed
路
4Comments
ChrisLoer
路
3Comments
jmkiley
路
3Comments
friedbunny
路
4Comments
Most helpful comment
@mpuchala, thank you for reaching out. In normal circumstances you should be able to use the SNAPSHOT containing this fix. I just double checked the nightly builds and there seems to be a problem with building. I'm fixing this in https://github.com/mapbox/mapbox-gl-native/issues/5187.