ElementMarker to Marker in the codebasecc @mourner @jfirebaugh @lyzidiamond @samanpwbb @tristen @1ec5
I really feel like we should not change ElementMarker to Marker and I haven't heard a compelling argument why it should be changed. Marker is classically generic to web maps, referring to dots on a map by any number of implementations. I feel like this is a step back from trying to indoctrinate Point as the word used.
My vote is for the following:
ElementMarker or DOMMarker. This makes it explicit that the browser renders them and can be manipulated by Front-end languages. It also makes it easier to point out their performance limitations. Leaflet's DivIcon is a good example of this being very clear in the name and how it's implemented.We should use "point" to refer to a geometric type or instance of that type, _independent of the implementation used to render it_. We should use "marker" and "symbol layer" as @lucaswoj defined them above.
So:
I disagree with choosing ElementMarker or Point over Marker. Marker is what most people are looking for, and they will not be surprised by the name or what it does. Adding Element to it does not significantly enhance the clarity. (We wouldn't rename Popup to ElementPopup.)
While there are two ways to make lower-case-m markers, most users will find upper-case-m Markers meet their expectations better. I feel good about nudging people towards Markers and clearly communicating that symbol layers are a more performant alternative.
I feel good about nudging people towards Markers and clearly communicating that symbol layers are a more performant alternative.
Have we benchmarked this? It would be great to be able to say "Symbol Layers are xx% faster" or "allow you to display xx% more markers".
This is done now 馃帀
Most helpful comment
We should use "point" to refer to a geometric type or instance of that type, _independent of the implementation used to render it_. We should use "marker" and "symbol layer" as @lucaswoj defined them above.
So:
I disagree with choosing
ElementMarkerorPointoverMarker.Markeris what most people are looking for, and they will not be surprised by the name or what it does. AddingElementto it does not significantly enhance the clarity. (We wouldn't renamePopuptoElementPopup.)