Manim: Removing temp ffmpeg's temp-files

Created on 28 Sep 2020  Â·  6Comments  Â·  Source: ManimCommunity/manim

Before partial movie files are generated by ffmpeg, scenefilewriter creates temp partial movie file and then move them and rename them with their definitive name (which is the hash of the animation).
Why ? Why not rendering directly partial movie files?
I think we should, if there is no objection, remove this and make ffmpeg directly render partial movie files.

enhancement good first issue help wanted refactor

All 6 comments

No objection here.

Is this still open? If it is, I would like to look into it.

@farahash yes! Please feel free to discuss here or open a PR.

@farahash and to assign yourself on this issue if you work on it ;)

@huguesdevimeux it doesn't seem like I can do that myself. Do I need to be added as a collaborator to the repo to get access?
(you can go ahead and assign it to me if that works too)

Sorry. I thought you could.

Now you are assigned !

Was this page helpful?
0 / 5 - 0 ratings