Manim: remove animation.update

Created on 8 Sep 2020  路  11Comments  路  Source: ManimCommunity/manim

Bsically the title. this method is useless. See the code and the comment :
https://github.com/ManimCommunity/manim/blob/5dd7bfe644e57d428deaad18f0ab8d3772d1ad01/manim/animation/animation.py#L115-L120

enhancement good first issue

Most helpful comment

Can I take this up ?

All 11 comments

We should add a deprecation warning

I think adding a warning for a while to give people some time to update is a better idea, similar to:
https://github.com/ManimCommunity/manim/blob/97de34692de7442845f9b935c6d1481784a739d4/manim/mobject/svg/tex_mobject.py#L334-L349

I think adding a warning for a while to give people some time to update is a better idea, similar to:

Yes (that's basically what @leotrs said lol)

I can add one with:

"animation.update(alpha) has been deprecated (due to its confusing name) "
"in favour of animation.interpolate(alpha). Please use interpolate() instead!"
let me know if it sounds good.

"animation.update() has been deprecated. Please use animation.interpolate() instead."

Fewer words, same meaning.

Can I take this up ?

Yes, thanks!

Sorry, I didn't see @meanmachin3 comment. Should I sent a pull request anyway?

@musabkilic It's okay :)
I'll work on something else. You could take it

@meanmachin3 Thanks! :)

closed due to #503

Was this page helpful?
0 / 5 - 0 ratings

Related issues

huguesdevimeux picture huguesdevimeux  路  7Comments

naveen521kk picture naveen521kk  路  5Comments

kolibril13 picture kolibril13  路  5Comments

PgBiel picture PgBiel  路  5Comments

naveen521kk picture naveen521kk  路  5Comments