Manageiq: Extend BaseTables for MiqExpression

[ThomasBuchinger]

I am looking for a way to enable expression methods to query more objects in the vmdb database. By diging MangeIQ code, I found that MiqExpressions are configured via a file vmdb/condif/miq_expression.yaml
https://github.com/ManageIQ/manageiq/blob/master/lib/miq_expression.rb

I tried to add some BaseTables myself and they seem to work. The objects I am most interested in are

• GenericObjects
• GenericObjectDefinitons
• CustomButtonEvents
• CustomAttributes
• Job

They all seem to work fine and I don't think adding those breaks any other part of the product. Is there a reasoning which objects go on that list and which ones don't? Would you accept a PR that adds those Objects (and maybe more) if they are tested?

[Fryguy]

@gtanzillo ?

[gtanzillo]

@ThomasBuchinger If adding those classes is working fine for it would be great if you could push that up in a PR with some examples of how you're using it and we can take a look at it.

[ThomasBuchinger]

@gtanzillo
The only classes I need at the moment are GenericObjects. The others are just looks-like-they-would-be-nice-to-have 😃

However I noticed that not all classes work, mostnotablyy EventStreams, *Request and *Task (e.g. ServiceTemplateProvision, Automation) and I could not figure out why it fails. These classes raise a "No Method 'root' for true-class"-error.
The errors I am getting seem to be related to the class itself and not dependent on any particular query. Since you guys have to support it, once they are added I was wondering if the list is more or less arbitrary or if there is some reasoning behind it

Anyway, I am going to send a PR, but it is not very high on my todo-list, so it will probably take some time

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

[Fryguy]

@gtanzillo Has this been completed? If not, can you unstale?

[gtanzillo]

@Fryguy This has not been done as of yet, I'll unstale it