Mailcow-dockerized: hard coded dba password

[bodsch]

After an update this morning my dovecot container stuffed my logfile with these errors:

dovecot-mailcow_1    | 1045 (28000): Access denied for user 'mailcow'@'localhost' (using password: YES) - trying again...
dovecot-mailcow_1    | 1045 (28000): Access denied for user 'mailcow'@'localhost' (using password: YES) - trying again...
dovecot-mailcow_1    | 1045 (28000): Access denied for user 'mailcow'@'localhost' (using password: YES) - trying again...
dovecot-mailcow_1    | 1045 (28000): Access denied for user 'mailcow'@'localhost' (using password: YES) - trying again...
dovecot-mailcow_1    | 1045 (28000): Access denied for user 'mailcow'@'localhost' (using password: YES) - trying again...

I found the hard-coded password here: https://github.com/mailcow/mailcow-dockerized/blob/master/data/Dockerfiles/dovecot/quarantine_notify.py#L33

After changing the password everything is in order again.

[rskallies]

I'm seeing the same behavior. I think these variables should be read from the ENV variables.

--- quarantine_notify.py    2019-02-08 09:51:55.985433633 +0100
+++ /usr/local/bin/quarantine_notify.py 2019-02-08 09:54:42.228776755 +0100
@@ -30,7 +30,7 @@
 def query_mysql(query, headers = True, update = False):
   while True:
     try:
-      cnx = mysql.connector.connect(unix_socket = '/var/run/mysqld/mysqld.sock', user='mailcow', passwd='9S6jd31ijEytZE9lQ8sWOxK34tg5', database='mailcow', charset="utf8")
+      cnx = mysql.connector.connect(unix_socket = '/var/run/mysqld/mysqld.sock', user=os.environ['DBUSER'], passwd=os.environ['DBPASS'], database='mailcow', charset="utf8")
     except Exception as ex:
       print '%s - trying again...'  % (ex)
       time.sleep(3)

[andryyy]

Meh. I’m sorry.