Magento2: Magento 2.3.4 - 404 error When click ''add to cart" from shared wishlist

[Vanitha-bujjinga]

Magento Version - 2.3.4

Steps to reproduce (*)

1. Login to a customer account and Add a product to wishlist.
2. Go to "wishlist" and click "Share wishlist".
3. Enter email id, message and send.
4. Logout from customer account.
5. Open a shared wishlist email, Click on "View Product" from email.
6. It landed on the shared wishlist products, Click the "Add to Cart" button from any product.

Expected result (*)

1. It should add a product to the cart and redirect it to the cart page.

Actual result (*)

1. It didn't add a product to the cart and it shows "404 error".
   URL: http://{host-name}/wishlist/shared/cart
   

I have executed this in plain vanilla Magento 2.3.4.

[m2-assistant[bot]]

Hi @Vanitha-bujjinga. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant[bot]]

Hi @swathishs. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

• [ ] 5. Add label Issue: Confirmed once verification is complete.

• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[swathishs]

@magento give me 2.4-develop instance

[magento-engcom-team]

Hi @swathishs. Thank you for your request. I'm working on Magento 2.4-develop instance for you

[swathishs]

@magento give me 2.4-develop instance

[magento-engcom-team]

Hi @swathishs. Thank you for your request. I'm working on Magento 2.4-develop instance for you

[Vanitha-bujjinga]

Any updates on this ticket?

[sabamanz00r]

Hi @Vanitha-bujjinga the issue is due to the interface HttpGetActionInterface implemented by vendor/magento/module-wishlist/Controller/Shared/Cart.php class.

class Cart extends \Magento\Framework\App\Action\Action implements HttpGetActionInterface
{
}

getSharedAddToCartUrl function in vendor/magento/module-wishlist/Helper/Data.php returns parameters with post but our Cart class is implementing HttpGetActionInterface interface.

public function getSharedAddToCartUrl($item)
{
    return $this->_postDataHelper->getPostData(
        $this->_getUrlStore($item)->getUrl('wishlist/shared/cart'),
        $this->_getCartUrlParameters($item)
    );
}

Solution : Remove HttpGetActionInterface interface or replace HttpGetActionInterface with HttpPostActionInterface in vendor/magento/module-wishlist/Controller/Shared/Cart.php class.

Change in core file is discourage. Add preference instead of changing core file.

[m2-assistant[bot]]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

• [ ] 5. Add label Issue: Confirmed once verification is complete.

• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

Hi @Vanitha-bujjinga thank you for your report, I'm not able to reproduce issue by steps you described on clean 2.4-develop
Result:

If you'd like to update the issue, please reopen it.

[Coosos]

Hi,

I reproduce this problem in 2.3.x, but is fixed with this commit (https://github.com/magento/magento2/commit/c3f9f3d733dc56624fb95e1b07f7916966b7f212) who apply in 2.4.x

[Vanitha-bujjinga]

Hi @Vanitha-bujjinga the issue is due to the interface HttpGetActionInterface implemented by vendor/magento/module-wishlist/Controller/Shared/Cart.php class.

class Cart extends \Magento\Framework\App\Action\Action implements HttpGetActionInterface
{
}

getSharedAddToCartUrl function in vendor/magento/module-wishlist/Helper/Data.php returns parameters with post but our Cart class is implementing HttpGetActionInterface interface.

public function getSharedAddToCartUrl($item)
{
    return $this->_postDataHelper->getPostData(
        $this->_getUrlStore($item)->getUrl('wishlist/shared/cart'),
        $this->_getCartUrlParameters($item)
    );
}

Solution : Remove HttpGetActionInterface interface or replace HttpGetActionInterface with HttpPostActionInterface in vendor/magento/module-wishlist/Controller/Shared/Cart.php class.

Change in core file is discourage. Add preference instead of changing core file.

Appreciate for your help, @sabamanz00r. It is working fine. Kudos...