Magento2: Small typo 'Magneto' in new Google Shopping Ads module (Magento 2.3.3)

[hostep]

Preconditions (*)

1. Access to Magento 2.3.3 (will be publicly available on 8 October 2019)

Steps to reproduce (*)

1. Setup vanilla Magento 2.3.3 installation (which comes with magento/google-shopping-ads version 3.0.1)
2. In the backend, go to Marketing > Advertising Channels > Google Shopping ads
3. Look at the popup

Expected result (*)

1. No typo 'Magneto', should be 'Magento'

Actual result (*)

1. Seeing a typo 'Magneto'.

Discussion

I can't seem to find the source code for this module publicly available, I only find this extension on the Marketplace, so if this issue is opened in the wrong place let me know.
Having access to the source code would allow us to send in PR's for these little problems btw 🙂

Ow btw: this popup is highly annoying, since you can't close it and therefore can't access anything else in the backend of Magento, so you need to change the url manually before you can access anything in the backend, which is not really user friendly. If I need to create a separate issue for this, let me know. Was created #24944

[m2-assistant[bot]]

Hi @hostep. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• [x] Summary of the issue
• [x] Information on your environment
• [x] Steps to reproduce
• [x] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@hostep do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• [x] yes
• [ ] no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

• [ ] 5. Add label Issue: Confirmed once verification is complete.

• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[YevheniiKR]

@magento i am working on it

[YevheniiKR]

@magento i am working on it

[m2-assistant[bot]]

Hi @YevheniiKR. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [x] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [x] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [x] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

• [ ] 5. Add label Issue: Confirmed once verification is complete.

• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[YevheniiKR]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @YevheniiKR. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @YevheniiKR, here is your Magento instance.
Admin access: https://i-24876-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[YevheniiKR]

can not find menu Advertising Channels. Investigeting now

[hostep]

@YevheniiKR, It's not available yet. And I don't know if it even will be available after 2.3.3 gets released, probably because this is yet another "open source but not publicly available extension brought to you by some Magento partner we don't know anything about".

[engcom-Bravo]

Hello @hostep. Thanks for reporting. I think we better wait yet for a day. Theoretically, tomorrow we shall see whether this feature is a part of vanilla package or not and so considering that we will see what to do next with it.

[Den4ik]

Also found typos at
CreateTest.php
and
Magento Composer Installer

[magento-engcom-team]

:white_check_mark: Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-21649 were created

Issue Available: @engcom-Bravo, _You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself._

[hostep]

Just FYI: @swetacedcoss created an issue for the not-being-able-to-close-the-popup-bug: https://github.com/magento/magento2/issues/24944

[sdzhepa]

Hello @hostep , @sadeeshmca

I received an update on this issue from the internal team a couple of minutes ago.

the fix for the typo has been deployed
Google shopping is a react app and users should see the change in a few minutes

To be sure before closing the issue, may I ask you to confirm it?

[m2-assistant[bot]]

Hi @sdzhepa. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• [ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

• [ ] 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[hostep]

@sdzhepa: yes confirmed, the typo has been fixed, thanks!