When using images with a horizontal ratio, and prevent the image generation from adding white space to the images, the thumbnail images in the gallery come out pixelated on the product page.
<var name="product_image_white_borders">0</var> in the view.xml of a theme (including the luma theme)product_image_white_borders is set to 0 in the view.xml of the activated themepub/media/catalog/product/cache/ folder.
Hi @NickdeK. Thank you for your report.
To help us process this issue please make sure that you provided the following information:
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
@magento give me 2.3-develop instance - upcoming 2.3.x release
For more details, please, review the Magento Contributor Assistant documentation.
@NickdeK do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?
Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.3-develop branchDetails
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!
[ ] 5. Verify that the issue is reproducible on 2.2-develop branch. Details
- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
[ ] 6. Add label Issue: Confirmed once verification is complete.
[ ] 7. Make sure that automatic system confirms that report has been added to the backlog.
:white_check_mark: Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-18589 were created
Issue Available: @engcom-Alfa, _You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself._
Same is happening for the mini cart. If product_image_white_borders is false, the product image is stretched until it fits inside a square (75px x 75px for the Luma theme).
@NickdeK I'm just wondering what's the expected result exactly? For the image to be zoomed-in and cropped until it fits the specified width and hight as declared in view.xml?
@erfanimani I don't think the default behaviour should be to crop the image; essential product information may be lost depending on the content. My current fix is to just resize the image with CSS to fit the container and align it in the center/middle of the container.
Hi @NickdeK, @NickdeK.
Thank you for your report and collaboration!
The issue was fixed by @NickdeK in https://github.com/magento/magento2/pull/23884
The fix will be available with the upcoming 2.3.4 release.
Issue also exists in minicart. Sadly, the fix #23884 doesn't work for the minicart.