Magento2: Label for custom attributes on checkout

Created on 25 Jun 2019  路  18Comments  路  Source: magento/magento2

I have three custom attributes for customer address that not show the label on checkout

Preconditions (*)

  1. Magento 2.3.0
  2. PHP 7.1+

Steps to reproduce (*)

  1. Create custom customer address attribute
  2. Set label
  3. Go to checkout
  4. Fill attribute
  5. Go to payment

Expected result (*)

  1. Show the label of attribute and value
    image

Actual result (*)

  1. The attribute code is shown
    image
Customer Eav Confirmed Format is valid Ready for Work Reproduced on 2.2.x Reproduced on 2.3.x

Most helpful comment

Another commit related:

  • 6d985af3486280a5a672ef32681a6cdb2a148aa3

All 18 comments

Hi @manuelcanepa. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • [ ] Summary of the issue
  • [ ] Information on your environment
  • [ ] Steps to reproduce
  • [ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@manuelcanepa do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • [ ] yes
  • [ ] no

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

  • [ ] 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • [ ] 6. Add label Issue: Confirmed once verification is complete.

  • [ ] 7. Make sure that automatic system confirms that report has been added to the backlog.

@magento give me 2.3-develop instance

Hi @manuelcanepa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

Hi @manuelcanepa, here is your Magento instance.
Admin access: https://i-23400-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

Issue is confirmed. In EE you can create a custom attribute from backend, in CE you need to create a custom attribute from module, but once create, the label does not shown: https://github.com/magento/magento2/blob/c7c66ad979e6bd2ee9e268e1d5d071772737944f/app/code/Magento/Checkout/view/frontend/web/js/model/address-converter.js#L61-L69 is not mapped on array

:white_check_mark: Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-17809, MC-17810 were created

Issue Available: @engcom-Bravo, _You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself._

Hi @sudheers-kensium. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • [ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
  • [ ] 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

  • [ ] 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • [ ] 4. If the issue is not relevant or is not reproducible any more, feel free to close it.


@magento give me 2.3-develop instance

Hi @manuelcanepa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

Hi @manuelcanepa, here is your Magento instance.
Admin access: https://i-23400-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

Issue is confirmed

Good Afternoon Manuelcanepa,

Could you please let me know if you will be submitting a fix for this ticket. I have tested your own fix and it is working on my local. If you will not be submitting the fix, I can submit it so that the fix can be completed. If you will fix it then I will remove the ticket from my queue so that you may take it.

Thank you,
Sudheer

Hi, you can submit the fix.

Hello @manuelcanepa and @sudheer-gajjala

I occasionally found that internal Magento team almost complete work to fix this issue.
At this moment code is passed code review and should be on QA stage soon.
The fix will be delivered with internal PR into 2.3-develop branch.
Related internal Jira ticket MC-19152 this number will be in the commit message.

As soon as it will be delivered, I will provide more details and commits here and close this issue

Hi @sdzhepa. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • [ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
  • [ ] 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

  • [ ] 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@manuelcanepa ,

Thank you for your report and collaboration!

The issue has been fixed by Magento team in the scope of internal Jira tickets MC-19152 and MC-19894
The fix has been delivered into 2.3-develop branch

Related commit(s):

  • 22c4ee1413212f4b55cff5014d48966c26582fe5
  • db7a3a1369d0c76422c56af179ab61f5b5d679e5

Another commit related:

  • 6d985af3486280a5a672ef32681a6cdb2a148aa3
Was this page helpful?
0 / 5 - 0 ratings