Hi @tuongnv-ub. Thank you for your report.
To help us process this issue please make sure that you provided the following information:
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
@magento-engcom-team give me $VERSION instance
where $VERSION
is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.
@tuongnv-ub do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
issue confirmed. We get the same issue.
Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
Issue: Format is valid
will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid
appears.[x] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description
label to the issue by yourself.
[ ] 3. Add Component: XXXXX
label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.3-develop
branchDetails
- Add the comment @magento-engcom-team give me 2.3-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop
branch, please, add the label Reproduced on 2.3.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!
[ ] 5. Verify that the issue is reproducible on 2.2-develop
branch. Details
- Add the comment @magento-engcom-team give me 2.2-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop
branch, please add the label Reproduced on 2.2.x
[ ] 6. Add label Issue: Confirmed
once verification is complete.
[ ] 7. Make sure that automatic system confirms that report has been added to the backlog.
@tuongnv-ub,
XamPP Server Localhost
Windows 10
This is not a valid environment, please check https://devdocs.magento.com/guides/v2.3/install-gde/system-requirements-tech.html
@orlangur But a LOT of people do their development work on windows.
This change is not deliberate; it's an error introduced by Magento and their Vagrant-only development ritual.
magento\framework\View\Element\Template\File\Validator.php
/**
* Checks whether path related to the directory
*
* @param string $path
* @param string|array $directories
* @return bool
*/
protected function isPathInDirectories($path, $directories)
{
if (!is_array($directories)) {
$directories = (array)$directories;
}
$realPath = $this->fileDriver->getRealPath($path);
foreach ($directories as $directory) {
if (0 === strpos($realPath, $directory)) {
return true;
}
}
return false;
}
$realPath
was added in 2.3.0 and does not return the expected slashes.
$realPath = 'C:\Server\Apache24\htdocs\magento-2.3\vendor\magento\module-theme\view\frontend\templates\page\js\require_js.phtml'
$directory = 'C:/Server/Apache24/htdocs/magento-2.3/vendor/magento/module-theme'
strpos
cannot return 0 on Windows.
@00110000,
a LOT of people do their development work on windows
It means nothing but they do their development wrong and at their own risk. There are a lot of options nowadays, like Docker, Vagrant or other virtualization technics available for Windows.
Windows is not supported, was never supported and always led to some bugs. Patches for Windows compatibility are not acceptable in this repo.
The only thing Magento lacks here is proper environment check, similar to an unsupported PHP version check. Hope it will change soon.
@tuongnv-ub @00110000 -> https://www.howtogeek.com/249966/how-to-install-and-use-the-linux-bash-shell-on-windows-10/
@00110000 i'm know a guy, who works with WSL a long time, and have no issue with it. so this may be a good solution
@engcom-backlog-nazar , @00110000 . Thanks for sharing. I'm Setup and working with WSL as well.
@engcom-backlog-nazar would be great to have such setup described somewhere in DevDocs for Windows guys. It would be much more friendly than just pointing to system requirements: https://github.com/magento/magento2/blob/2.3-develop/app/bootstrap.php#L17
Most helpful comment
@tuongnv-ub @00110000 -> https://www.howtogeek.com/249966/how-to-install-and-use-the-linux-bash-shell-on-windows-10/