Magento2: Can't Cancel Order

[friendscottn]

Preconditions (*)

1. 2.2.6
2. Allow guest checkout
3. Have a coupon you can use

Steps to reproduce (*)

1. Checkout as a guest using a valid coupon
2. After placing the order, register an account using the create account button on the order confirmation page.
3. Login to the admin
4. Make sure to get the order to a processing state.
5. Try to cancel the order

Expected result (*)

1. The order is canceled

Actual result (*)

1. You receive the generic errror "You have not canceled the item"
2. The underlying error is:

SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (`mage`.`salesrule_customer`, CONSTRAINT `SALESRULE_CUSTOMER_RULE_ID_SALESRULE_RULE_ID` FOREIGN KEY (`rule_id`) REFERENCES `salesrule` (`rule_id`) ON DELETE CASCADE), query was: INSERT INTO `salesrule_customer` () VALUES () {"exception":"[object] (Zend_Db_Statement_Exception(code: 23000): SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (`mage`.`salesrule_customer`, CONSTRAINT `SALESRULE_CUSTOMER_RULE_ID_SALESRULE_RULE_ID` FOREIGN KEY (`rule_id`) REFERENCES `salesrule` (`rule_id`) ON DELETE CASCADE), query was: INSERT INTO `salesrule_customer` () VALUES () at /www/vendor/magento/zendframework1/library/Zend/Db/Statement/Pdo.php:235, PDOException(code: 23000): SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (`mage`.`salesrule_customer`, CONSTRAINT `SALESRULE_CUSTOMER_RULE_ID_SALESRULE_RULE_ID` FOREIGN KEY (`rule_id`) REFERENCES `salesrule` (`rule_id`) ON DELETE CASCADE) at /www/vendor/magento/zendframework1/library/Zend/Db/Statement/Pdo.php:228)"} []

Related Issues

https://github.com/magento/magento2/issues/16779

[magento-engcom-team]

Hi @friendscottn. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• [ ] Summary of the issue
• [ ] Information on your environment
• [ ] Steps to reproduce
• [ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@friendscottn do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• [ ] yes
• [ ] no

[magento-engcom-team]

Hi @maheshWebkul721. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!
  

• [ ] 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• [ ] 6. Add label Issue: Confirmed once verification is complete.

• [ ] 7. Make sure that automatic system confirms that report has been added to the backlog.

[maheshWebkul721]

@magento-engcom-team give me 2.2-develop instance

[magento-engcom-team]

Hi @maheshWebkul721. Thank you for your request. I'm working on Magento 2.2-develop instance for you

[magento-engcom-team]

Hi @maheshWebkul721, here is your Magento instance.
Admin access: http://34.228.235.121/i-19230-2-2-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[magento-engcom-team]

@maheshWebkul721 Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96384 were created

[machaka]

Hi there, I'm able to reproduce it, I'm facing the same issue on magento 2.2.6

[dudzio12]

Same for me

[Winfle]

Reproducible on 2.2.7-dev

[magento-engcom-team]

Hi @KravetsAndriy. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

• [ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!
  

• [ ] 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• [ ] 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

[SamB-GB]

Does anyone know if this is an issue in 2.2.3?

[Winfle]

@SamB-GB Hello. It doesn't throw exception, however expected behaviour is not valid, because after making an account, it doesn't increase coupon usage for newly created customer.
So, I think, that make reverse bugs, however, if you you're interested only in canceling order, you won't have a bug, described here.

[magento-engcom-team]

Hi @engcom-backlog-tomash. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

• [ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!
  

• [ ] 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• [ ] 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

[ghost]

@magento-engcom-team give me 2.3.0 instance

[magento-engcom-team]

Hi @engcom-backlog-tomash. Thank you for your request. I'm working on Magento 2.3.0 instance for you

[magento-engcom-team]

Hi @engcom-backlog-tomash, here is your Magento instance.
Admin access: https://i-19230-2-3-0.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[ghost]

@friendscottn, thank you for reporting this isuue. The latest released version of Magento (2.3.0) is not affected by this issue. After the order is invoiced you cannot cancel the order. By if the merchant ships the order without invoicing than order gets status processing and also he is able to cancel it until invoice is not created. In such conditions order has no problems with cancelation

[Winfle]

@engcom-backlog-tomash I think, when user makes guest order with coupon code and then registers an account, coupon code usage should be increased and coupon usage per customer should be increased , the same way as customer made account BEFORE checkout with given coupon.
In fact, coupon has been used, but amount of usages will be the same as before. This behaviour exists in 2.3.
If its not relevant to current scope ( Canceling an order), I can make separated issue.

[ghost]

@Winfle, yes please create new one if it's not already created.

[sidolov]

Hi @friendscottn. Thank you for your report.
The issue has been fixed in magento/magento2#19423 by @Winfle in 2.2-develop branch
Related commit(s):

• cede04f014733bffc5104f2e26579e8ce242f462
• 11480e8b44d26ecf8e692c1a3406423b1532031f
• 10fbf4041c98b12ee4bb19f09f04efc7856dfa60
• 1e2f3fbd5481b3eee6d7c049703c0d51b849c439
• 5ea6e7208099123c5e7f8df34607fca9ef03c650
• 9a63dad6a2958d07aa631bb0e971f17e3f6eda3b
• 36c2329505ca63c821fc8d7a553e6f35a4f3ae40
• fdf7da48088ffae823021e5a8be4429afa941404

The fix will be available with the upcoming 2.2.8 release.

[MageCloudTeam]

@sidolov the same issue in Magento 2.2.9

[magento-engcom-team]

Hi @friendscottn. Thank you for your report.
The issue has been fixed in magento/magento2#20577 by @p-bystritsky in 2.3-develop branch
Related commit(s):

• 5a24c411060934c8496830762704e5d07131a80a
• 44760ff282f67091c8eb325ce81c41655bdabc7a
• ae76c57fcbef3f0cc58c2599816dfec916567a85
• d8add8a90b22ce58f6688e3d6677c7623080fbe7
• 2fd017a4afe6f90e98f09fa154799dd8ab2a9d46
• 565d0b10ec4719a3e9d5befa05898a71329e86ea

The fix will be available with the upcoming 2.3.4 release.

[parekhreena]

The issue still happens with Guest Users. The issue originates from \Magento\SalesRule\Model\Coupon\UpdateCouponUsages::updateCustomerRuleUsages and this line $ruleCustomer->save(); was causing the issue. I am on enterprise version.

[mertgokceimam]

@magento-engcom-team Can you please release a patch for this on 2.2.x for EE customers. Orders can't be cancelled have big effect on stock values within the system

[simonmaass]

i am still having this issue in magento 2.3.3 CE: