Magento2: Magento 2.2.5 - Shopping Cart Remove Product ( PHP Fatal error )

Created on 11 Oct 2018 · 10Comments · Source: magento/magento2

Preconditions

Magento EE 2.2.5 without sample data is installed.
PHP 7.1.20

Steps to reproduce

Navigate to storefront as a logged in customer.
Click "Add to Cart" on the any Product.
Open mini shopping cart and click to "view and edit cart" link.
Open mini shopping cart click on delete icon next to product.
Click on delete icon next to product in shopping cart page.

Expected result

Page should reload with appropriate message eg. "Item has been already removed from cart. "

Actual result

Error log: PHP Fatal error: Uncaught Error: Call to a member function getQty() on boolean in /var/www/html/shop2dev_deployer/releases/289/vendor/magento/module-google-tag-manager/Model/Plugin/Quote/SetGoogleAnalyticsOnCartRemove.php:47

Clear Description Format is valid

Source

kapil-infobeans

👍2

Most helpful comment

@magento-engcom-team The issue here is that Magento\GoogleTagManager\Model\Plugin\Quote\SetGoogleAnalyticsOnCartRemove::afterRemoveItem does not add a conditional to check whether the $item exists before calling $item->getQty(), something like the following would fix:

public function afterRemoveItem(\Magento\Quote\Model\Quote $subject, $result, $itemId)
{
    $item = $subject->getItemById($itemId);

    if (!$item) {
        return $result;
    }

    $this->setItemForTriggerRemoveEvent($this->helper, $this->registry, $item, $item->getQty());

    return $result;
}

tr33m4n on 17 Oct 2018

👍2

All 10 comments

Hi @kapil-infobeans. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

[ ] Summary of the issue
[ ] Information on your environment
[ ] Steps to reproduce
[ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@kapil-infobeans do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

[ ] yes
[ ] no

magento-engcom-team on 11 Oct 2018

@magento-engcom-team give me 2.2.5 instance

kapil-infobeans on 11 Oct 2018

Hi @kapil-infobeans. Thank you for your request. I'm working on Magento 2.2.5 instance for you

magento-engcom-team on 11 Oct 2018

Hi @kapil-infobeans, here is your Magento instance.
Admin access: https://i-18536-2-2-5.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

magento-engcom-team on 11 Oct 2018

@magento-engcom-team Is it EE 2.2.5 instance? It's only reproducible on EE 2.2.5.

kapil-infobeans on 11 Oct 2018

I am able to reproduce this on Magento 2.2.1. Not consistently, but it is occurring under the same scenario.

aaugusto-efi on 16 Oct 2018

👍1

public function afterRemoveItem(\Magento\Quote\Model\Quote $subject, $result, $itemId)
{
    $item = $subject->getItemById($itemId);

    if (!$item) {
        return $result;
    }

    $this->setItemForTriggerRemoveEvent($this->helper, $this->registry, $item, $item->getQty());

    return $result;
}

tr33m4n on 17 Oct 2018

👍2

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[x] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

[x] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!
[ ] 5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
[ ] 6. Add label Issue: Confirmed once verification is complete.
[ ] 7. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team on 24 Oct 2018

HI @kapil-infobeans I'm not able to reproduce following steps your described, because google-tag-manager exist only in ee version, Please follow these guidelines for proper tracking of your issue. You can report Commerce-related issues in one of two ways:
You can use the Support portal associated with your account
or
If you are a Partner reporting on behalf of a merchant, use the Partner portal.

GitHub is intended for Magento Open Source users to report on issues related to Open Source only. There are no account management services associated with GitHub.