Magento2: Duplicated elements id in checkout page

Created on 29 Jan 2018 · 40Comments · Source: magento/magento2

Preconditions

Magento 2.1.10

Steps to reproduce

Go to Stores -> Configuration -> Sales -> Sales under Gift Options and set both Allow Gift Messages to YES
Put something in cart and go to checkout or cart page

Expected result

Two forms for gift messages having fields with unique ids

Actual result

Two forms for gift messages having fields with non unique ids

[DOM] Found 2 elements with non-unique id #gift-message-whole-from: (More info: https://goo.gl/9p2vKq) <input type="text" id="gift-message-whole-from" class="input-text" data-bind="value: getObservable('sender')"> <input type="text" id="gift-message-whole-from" class="input-text" data-bind="value: getObservable('sender')">

[DOM] Found 2 elements with non-unique id #gift-message-whole-to: (More info: https://goo.gl/9p2vKq) <input type="text" id="gift-message-whole-to" class="input-text" data-bind="value: getObservable('recipient')"> <input type="text" id="gift-message-whole-to" class="input-text" data-bind="value: getObservable('recipient')">



md5-47135b0cecd5c1dfbe17e8bc1164ea2b



[DOM] Found 2 elements with non-unique id #billing-new-address-form: (More info: https://goo.gl/9p2vKq) <fieldset id="billing-new-address-form" class="fieldset address">…</fieldset> <fieldset id="billing-new-address-form" class="fieldset address">…</fieldset>

Checkout GiftMessage Fixed in 2.2.x Fixed in 2.3.x Clear Description Confirmed Format is valid Ready for Work Reproduced on 2.2.x Reproduced on 2.3.x up for grabs

Source

angelo983

👍5

Most helpful comment

Same situation for me on a new 2.2.3 install.

bmzero on 4 Apr 2018

👍4

All 40 comments

@angelo983, thank you for your report.
We've acknowledged the issue and added to our backlog.

magento-engcom-team on 30 Jan 2018

@angelo983 did you got any solution for this ? I am getting this error in Magento 2.1.8 even when both Allow Gift Messages are set to No

psuthar12 on 11 Feb 2018

👍2

Similar report: #14126

ishakhsuvarov on 16 Mar 2018

We have this error as well for other elements with non-unique id #... running on Magento 2.2.3 and Gift Options and set both Allow Gift Messages to NO

EmilyPepperman on 22 Mar 2018

Hi @EmilyPepperman I've this similar issue: (in checkout page)

[DOM] Found 2 elements with non-unique id #send2: (More info: https://goo.gl/9p2vKq [^])
<button type=?"submit" class=?"action action-login secondary" name=?"send" id=?"send2">?…?</button>?

Anyone has experienced same situation?

Thanks,

bruno-serfe on 29 Mar 2018

Same situation for me on a new 2.2.3 install.

bmzero on 4 Apr 2018

👍4

any solution ?

mariamghalleb on 13 Apr 2018

👍1

Also having this problem.

mutantturkey on 14 Apr 2018

Similar issue on 2.2.3

[DOM] Found 2 elements with non-unique id #billing-new-address-form:

Noticed that Cash on delivery payment method form had same id (#billing-new-address-form) as Authorize.net method.

Solved by disabling the Cash On Delivery method.

Magento team should use unique html ids for every method templates.

zennco on 17 Apr 2018

Hi @Deep256 any update on this? thanks!

bruno-serfe on 18 Apr 2018

HI @bruno-serfe.
Yes. I want create a pull-request with update today.

Deep256 on 20 Apr 2018

👍2

Hi @Deep256 will this be ready in Magento v2.3? thanks

bruno-serfe on 30 Apr 2018

Hi @angelo983. Thank you for your report.
The issue has been fixed in magento/magento2#15585 by @julienanquetil in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

magento-engcom-team on 2 Jun 2018

👍2

Hi @angelo983. Thank you for your report.
The issue has been fixed in magento/magento2#15705 by @julienanquetil in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

sidolov on 5 Jun 2018

Hi @angelo983. Thank you for your report.
The issue has been fixed in magento/magento2#16264 by @chirag-wagento in 2.1-develop branch
Related commit(s):

c9e5239a2786b1169f6f06f61f9589b8078c0865

The fix will be available with the upcoming 2.1.15 release.

sidolov on 23 Jun 2018

👍1

Hello @sidolov

As I can see from @julienanquetil code, it fixes only gift message related IDs. What about billing address form? Is it extracted in separate issue?

enl on 10 Jul 2018

👍1

Running into this on 2.2.4 just enabled multiple payment methods now checkout does not work.
Could someone please make an extension/hot-fix this as a temporary measure?
Multiple #billing-new-address-form

Or tell me which file I can edit to make this fix work?

LiamKarlMitchell on 24 Jul 2018

I fixed this isue by changing the following setting in Configuration:
Sales - Checkout - Checkout options:
Display Billing Address On : -> Set to "Payment page".

This has solved the issue for me.

jorisssss on 10 Sep 2018

👍1

Also a problem with #customer-email in authentication-popup.html

LiamKarlMitchell on 11 Sep 2018

I fixed this isue by changing the following setting in Configuration:
Sales - Checkout - Checkout options:
Display Billing Address On : -> Set to "Payment page".

This has solved the issue for me.

worked for us jorisssss

xceed-will on 13 Sep 2018

Hi Guys, just wondering... I've updated to v2.2.6 but I can still see the issue, is this available in that new release or we'll need to wait for v2.3 ? thanks!

bruno-serfe on 19 Sep 2018

@bruno-serfe reopening to get it verified once more

ishakhsuvarov on 20 Sep 2018

Hi guys, I am looking at this issue in 2.2-develop (2.2.7-dev) and it seems to be fixed.
Can somebody advise what needs to be done in here?

diazwatson on 7 Oct 2018

Hi @diazwatson. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[x] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

[x] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[x] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!
[ ] 5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
[ ] 6. Add label Issue: Confirmed once verification is complete.
[ ] 7. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team on 7 Oct 2018

@magento-engcom-team give me 2.3-develop instance

diazwatson on 16 Oct 2018

Hi @diazwatson. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team on 16 Oct 2018

Hi @diazwatson, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-13415-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

magento-engcom-team on 16 Oct 2018

Hey guys I am trying to reproduce this issue with the 2.3-develop instance provided but when I try to add a product to the cart I get a message saying:
Your session has expired

Any idea why this is happening?

If this helps, I have also tested that branch in my local environment and the issue seems to be fixed there.

diazwatson on 16 Oct 2018

Hi @TomashKhamlai. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!
[ ] 5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
[ ] 6. Add label Issue: Confirmed once verification is complete.
[ ] 7. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team on 14 Dec 2018

@magento-engcom-team give me 2.3.0 instance

TomashKhamlai on 14 Dec 2018

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento 2.3.0 instance for you

magento-engcom-team on 14 Dec 2018

Hi @TomashKhamlai, here is your Magento instance.
Admin access: https://i-13415-2-3-0.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

magento-engcom-team on 14 Dec 2018

@magento-engcom-team give me 2.2.7 instance

TomashKhamlai on 14 Dec 2018

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento 2.2.7 instance for you

magento-engcom-team on 14 Dec 2018

Hi @TomashKhamlai, here is your Magento instance.
Admin access: https://i-13415-2-2-7.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

magento-engcom-team on 14 Dec 2018

On 2.3.0 gift-message-whole-to-giftOptionsCartItem-1
screenshot_20181214_153556

TomashKhamlai on 14 Dec 2018

The same on 2.2.7
Also it looks like it needs some cosmetic repair too.

TomashKhamlai on 14 Dec 2018

@TomashKhamlai Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97159, MAGETWO-97160 were created

magento-engcom-team on 14 Dec 2018

Hi @angelo983.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

The fix will be available with the upcoming 2.2.10 release.

magento-engcom-team on 10 Jul 2019

Hi @angelo983.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

The fix will be available with the upcoming 2.3.3 release.

magento-engcom-team on 10 Jul 2019

Was this page helpful?