Magento2: Empty attribute label is displayed on product page when other language used.

Created on 1 Sep 2017  路  10Comments  路  Source: magento/magento2


Preconditions


  1. Clean instance of Magento 2.1.8
  2. Store displayed in some foreign languege i.e. pl_PL
  3. Simple product with some attribute visible on product page.

Steps to reproduce

  1. Go to product page.
  2. See attribute label ('none' translated to your foreign language) in the attributes section/

Expected result

  1. 'none' label translated to other languages i.e. polish lang - 'brak' should not be displayed
  2. comparisson in line 37 of app/code/Magento/Catalog/view/frontend/templates/product/view/attribute.phtml is changed to if ($_attributeLabel != __('none')) in order to not display 'none' translated to foreign language

Actual result

  1. In the template app/code/Magento/Catalog/view/frontend/templates/product/view/attribute.phtml line 37 you have followin comparisson: if ($_attributeLabel != 'none') but at this part of code $_attributeLabel is already translated.

Fixed in 2.1.x Fixed in 2.2.x Fixed in 2.3.x Clear Description Confirmed Format is valid Ready for Work Reproduced on 2.1.x Reproduced on 2.2.x bug report

All 10 comments

FYI: This has been reported may times before: #9295, #9161, #9531,

Ok, so, there are (at least) two attempts to fix this issue. Both merged to develop and none to 2.1-develop:

According to my understanding newer PR is a correct one (no reason to forbid "none" translation, valid scenario is described in this issue), thus it would be nice to revert #6257.

Thoughts? Cc: @vrann @miguelbalparda

@nowszy, thank you for your report.
The issue is already fixed in develop branch
But we will consider to backport the fix to patch releases

Internal ticket to track issue progress: MAGETWO-75315

@orlangur, the more correct in 2.2-develop branch. Remove translate="true" from layout and do not translate "none" in template.

@maksek ok, thanks for sorting this out 馃憤

Internal ticket to track issue progress: MAGETWO-80884

@nowszy thank you for your report. The issue is already fixed in 2.2-develop branch (PR: #11168 by @maksek ) and will be available in the Magento 2.2.2 release

Internal ticket to track issue progress: MAGETWO-80770

Hi @nowszy. Thank you for your report.
The issue has been fixed in magento/magento2#13532 by @hostep in 2.1-develop branch
Related commit(s):

  • 00f29c07cb08921009297594758da79d0850f05a

The fix will be available with the upcoming 2.1.13 release.

Was this page helpful?
0 / 5 - 0 ratings