Magento2: Canceled invoice can be canceled again

[redelschaap]

A canceled invoice can be canceled again. I think \Magento\Sales\Model\Order\Invoice::cancel should check whether the invoice can be canceled before executing all cancel operations.

Preconditions

1. Tested on Magento 2.1.5

Steps to reproduce

1. Load a canceled invoice programmatically
2. Call $invoice->cancel()

Expected result

1. Throw an exception saying the invoice has already been canceled.

Actual result

1. The invoice gets canceled twice, so order amounts are also being adjusted twice.

[magento-engcom-team]

@redelschaap, thank you for your report.
We've created internal ticket(s) MAGETWO-75779 to track progress on the issue.

[osrecio]

Maybe Adding a Guard Clause in \Magento\Sales\Model\Order\Invoice::cancel with:

public function cancel()
{
        if (!$this->canCancel()) {
            return $this;
        }
       ...
}

can Solve the problem.

If you accept this solution @okorshenko @magento-engcom-team @veloraven can proceed to create PR.

[okorshenko]

We need to backport this into 2.2-develop

[osrecio]

Working on it

[osrecio]

Created 2.2-develop Backport @okorshenko

[okorshenko]

Hi @redelschaap the issue has been fixed in 2.2-develop branch and will be available in 2.2.2 soon

[okorshenko]

Hi @redelschaap the issue has been fixed in 2.2-develop branch and will be available in 2.2.2 soon