Magento2: Magento 2.1.4 Admin Panel Order Billing/Shipping Address Edit

[Joker2099]

Preconditions

1. Magento 2.1.4
2. PHP 7.0.15
3. MYSQL 5.6.35

Steps to reproduce

1. View pending/processing order in the admin panel
2. Edit billing or shipping address of the order
3. Change State/Region field by selecting it from dropdown menu
4. Save

Expected result

1. State/Region changed to new or kept the same if there are no changes

Actual result

1. State/Region doesn't change. Form fields submit empty region text variable but the region_id is being submitted correctly, therefore, state/region text saves as blank.

In the source code of the form, all of the States and their ID's are properly generated in json format. I searched for tips and workarounds but couldn't find anything related. What I found though that the RegionUpdater is responsible for this part of the form, though I was not able to locate the source JS file for it.
I see that this seems to be a duplicate issue but this bug still exists in version 2.1.4.

[heyqule]

Confirmed for 2.1.6 as well. State/Region becomes blank after save.

Update: If I go to the edit form again. I do see the state/region are changed. But it's not showing on the order view page

[Joker2099]

@heyqule
Correct, I narrowed it down to that region_id is being passed to the database (that's why the dropdown shows correct state on edit each time) but the region text isn't. Though if you change the country to lets say Afghanistan, you are able to type in the region manually and it's being passed to the database.

I am still digging the files, if I find a workaround or solution I will post here.

[heyqule]

I got the solution. I added an observer for "customer_address_format" to check whether the region name is empty when region_id exists. If the condition matches, the observer will pull the region name based on region ID and save it to the address. That fixes the issue.

But the correct way is to patch it in execute() of Magento\Sales\Controller\Adminhtml\Order\AddressSave. That should be done between $address->addData($data); and $address->save();

However, my observer would fix the address if there are other controllers handle the address the same way as Magento\Sales\Controller\Adminhtml\Order\AddressSave.

I'll submit a pull request to fix it in execute() and post my observer when I arrive to work later.

[heyqule]

https://gist.github.com/heyqule/2e6f2ebfd1717031a3c30e1b156587c0

Here is the observer I use at the moment

[Joker2099]

Works. Tested it on 2.1.4.

[sharkpee]

@heyqule
@Joker2099
@southerncomputer
I tried your method but failed,would you mind tell me why ?

[Joker2099]

@sharkpee Create another folder under etc called adminhtml and put events.xml in there. Make sure the class names in the registration.php is the same as the path name to your files and under module.xml

Once done run
bin/magento setup:upgrade
bin/magento setup:di:compile
bin/magento cache:flush

See if that works and let us know.

Edit: In my case I had to turn on the custom module to be able to run the code, so go into admin panel and turn on your module or do it via SSH

[sharkpee]

TKS

[sharkpee]

TKS

[Joker2099]

@sharkpee Make sure when you do any changes you are in Developer mode first of all. Look in the debug.log & system.log for compilation errors when you compile. It may take a few tries to correctly compile.

If you are still not able to run it, I will install M 2.1.7 and try it on my end later today. As for 2.1.4 which I am still using due to not too many bugs, that fix is working perfectly.

[southerncomputer]

php bin/magento setup:upgrade
php bin/magento setup:di:compile
php bin/magento deploy:mode:set production
php bin/magento cache:flush

service php-fpm restart
service varnish restart
service nginx restart
chown -R yourusername *

the two orange error boxes are because you did not recompile/re deploy/cache flush!

[sharkpee]

@Joker2099 @heyqule @southerncomputer Thanks a lot! It works in 2.1.7.
I run the cmd below:
php bin/magento setup:upgrade
php bin/magento setup:static-content:deploy
php bin/magento indexer:reindex
php bin/magento cache:flush

[Joker2099]

Issue still present in 2.1.8.

That fix still works in 2.1.8 though.

[wilzon008]

Issue still present in 2.1.9. Why has this not been corrected in the latest update?

[magento-engcom-team]

@Joker2099, thank you for your report.
The issue is already fixed in develop branch, 2.2.0

[mazestricks]

Thanks, @heyqule tested your module and it worked on my end. I have the same problem using Magento 2.1.3

[oabreu]

Hi @heyqule , @sharkpee , @Joker2099 and everyone, this may be a dump question, but we are new on Magento, we have CE 2.1.7, and we were having this bug, so we applied this patch, and we are getting this error now when we try to see an order details on the cpanel
"Information Changes have been made to this section that have not been saved. This tab contains invalid data. Please resolve this before saving."

And this is what we are getting on the php log
"PHP Fatal error: Class 'HQ\MissingAddressRegionFix\Observer\AddressFormat' not found in ourPath/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php on line 93"

Can you guys please help us with this? Thanks

[southerncomputer]

@oabreu app/code/HQ/MissingAddressRegionFix/Observer/AddressFormat.php is where observer.php should go! it is named wrong

[oabreu]

Thank you very much @southerncomputer , i called it addressFormat.php because of this picture

But now i changed the name to AddressFormat.php and is working :)