Magento2: Upgrade ZF components. Zend_Feed

Created on 13 Apr 2017  路  6Comments  路  Source: magento/magento2

Description
Upgrade components from ZF1 to ZF2

As a long term goal, we would like to eliminate knowledge about 3rd party libraries from Magento code base. Magento code still can use 3rd party libraries, but they must be wrapped by Magento interfaces and classes (adapters) so that 3rd party libraries can be easily substituted by newest versions or alternative implementations.

Acceptance Criteria

  1. Magento interfaces are defined and can be used instead of ZF1 classes in Magento code
  2. Default implementations for new interfaces are defined and configured as the preferences for new interfaces
  3. Client code of the ZF1 components is refactored to use Magento interfaces
  4. Zend classes are used as private services in Magento adapters
  5. Backward compatibility is preserved
  6. ZF1 components are updated to ZF2

List of the components

# | Component Name
(total usages count) | Module Name | Usages Count
------------- | ------------- | ------------- | -------------
1|Zend_Feed (total: 3)|MagentoRss|3

Fixed in 2.3.x Format is not valid up for grabs

Most helpful comment

I would like to take this one for start please.

All 6 comments

I would like to take this one for start please.

@okorshenko I'm looking to pick this issue up, but I'm struggling with point 5 of BC. What do you mean with BC in this regard? If we swap out the hardcoded Zend_Feed in app/code/Magento/Rss/Model/Rss.php with an adapter, it'll break BC in some cases.

@okorshenko Thank you for report
Please use the issue reporting guidelines to report an issue. Please, edit issue description and include the preconditions, the steps required to reproduce, the actual result, and the expected result.

@okobchenko @korosti2 @peterjaap I find it very hard to understand what's happening here, as the pull request is waiting: https://github.com/magento/magento2/pull/9347

Closing the issue. See PR details here: https://github.com/magento/magento2/pull/9347

Was this page helpful?
0 / 5 - 0 ratings