Magento2: Media Uploader Issues

Created on 11 Jan 2016  路  24Comments  路  Source: magento/magento2

Hi

I want to raise some issues on the hideous and bloated Media uploader for Magento 2 and shoot the person who built this pile of crap.

  • Cannot upload SVG images
  • Poor UI and UX
  • No indication of uploaded content
  • Firefox has thousands of issues including JS issues with not allowing the upload option to show
  • The upload button is text and should be made to a button
  • No history tracking

It does not even work half the time in Chrome or Firefox. Since the last update the design has also broken and why does it scale full screen to to the right?

feature request

Most helpful comment

Internal issue MAGETWO-52993 to address SVG file upload.

All 24 comments

screen shot 2016-01-11 at 3 28 20 pm

Should be a button ^

screen shot 2016-01-11 at 3 28 10 pm

Why does it scale to the right half the screen?

Is is possible to use another Image or File Manager; OpenCart has a better manager than this.

"...and shoot the person who built this pile of crap."

That's _completely_ unnecessary and unprofessional, @Khaleel.

If no emotion is shown then how can we progress.

*"If no emotion is shown then how can we progress."

The answer is simple: we're professionals, a fact demonstrated by the issues resolved in this channel without (or in spite of) emotional appeal. Note that there is a massive difference between expressing frustration and threatening violence (which you did). Do not make that mistake again please. It adds nothing of merit to the report (which in itself is quite valuable), and similar conduct in the future would render you unwelcome for continued participation. Feel free to express frustration if you must, but do so in a civil manner.

We're all developers here, and we know how frustrating it is to encounter bugs. Our aim is to move the software forward with the help of the folks using it.

Hi
Your comments are fair and yes we are all developers and we should try to work better via communication.

So, is there any updates of improving the media uploader - adding search, history and better archiving and UI and UX folder structures. Support for SVG - adding Arabic and other language support via UTF due to charset issues..

Thanks

@antboiko Anton--does this fall under product creation ownership? if so please accept and route as either issues or feature requests as applicable

I was just creating an issue for the SVG point and saw this, so I'll put my info here:

SVGs can't be uploaded through the admin.

Steps to reproduce

  1. Create a static block
  2. Add an image
  3. Try to upload an SVG

Expected result

  1. SVG is uploaded and can be added through the WYSIWYG editor

Actual result

  1. 'Please wait' spinner appears, then nothing has changed.

Notes

  • Other image formats are working fine, just not SVGs
  • No related errors are given and nothing related in the logs
  • Magento 2.0.4

This applies anywhere inside of M2 - even the latest GA releases; you cannot upload any form of SVG

Seems a rather odd choice as Magento 2 is attempting to push forward with up to date technologies.

@BenSpace48 Precisely I have tested on an Nginx build too. SVG work fine in the server - just cannot upload them!

Internal issue MAGETWO-52993 to address SVG file upload.

Hello. We will fix the error messages to make it more clear in scope of MAGETWO-52993 but allowing upload of SVG files will take more time. SVG files are not currently supported by GD library used by Magento. We would have to move to another library (ImageMagick?) and it requires more changes. The full work is tracked in scope of MAGETWO-53778.

Thank you for the update! 馃槃

Hello @Khaleel, this issue has been fixed in the 2.1.0 Release, that's why I'm closing it. If you any questions or additional information regarding the issue feel free to reopen it or create a new one.

@Khaleel @BenSpace48 The seems to be a lot of interest in SVG file upload. The problem is security. SVG format can include JavaScript and there are no good protections for it. The only solutions would be to convert it to something (JPEG/PNG) by external process and only then use, but i assume it doesn't make sense to use SVG anymore. It's highly unlikely we will add support for it unless there is major reason. Can you tell me what is reason to use SVG for image upload for you?

@piotrekkaminski That's a good point, I presume that's also why Github doesn't support uploading SVGs to comments.

For our use case we needed to use SVGs for responsive reasons and consistency with the skin icons (all skin icons are SVG). There are quite a few advantages to using SVG over JPG/PNG, just a few are:

  • Small size. SVG image elements take up much less space than their twins created in raster format
  • Flexibility, SVGs can easily be animated/changed
  • Scalability without changing the image quality. It is widely used for devices with screens Retina and those close to them

We had to resort to using a JPG which obviously did work but doesn't have the same quality as an SVG.

Thanks for the answers @BenSpace48. Also SVG are generally becoming more and more secure. You could possible drop the poor WYSIWYG editor and replace it with one the that validates them better. I noticed TinyMCE has issues with Arabic and other languages.

I agree though, SVG is really the way to go with Front End Development; beyond retina the quality is superior and it is being adopted across the web. @piotrekkaminski it seems your more of a Back End Developer as you would have placed them in by default.

I look forward to being able to use SVG's. It's a must have for quality responsive design.

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

Here is the extension I made: https://github.com/iMi-digital/magento2-module-svg-product-images - pull requests are welcome

@amenk I have used the extension which you made to allow SVG images on Magento 2 but it's not working as expected. I would like to upload the product images as SVG format.
Could you please suggest me what should I do to allow SVG images on Magento 2?

It's best if you create a detailed issue on our github repo

@amenk I have installed the extension which is allow to upload SVG on product images https://github.com/iMi-digital/magento2-module-svg-product-images as per your suggestion. Also I installed Imagemagick on my Xampp but still can't upload SVG images.

Please comment.

Was this page helpful?
0 / 5 - 0 ratings