Magento-lts: Change BN code for PayPal

[schmengler]

To distinguish OpenMage from Magento 1, you should change the BN code for PayPal:

https://github.com/OpenMage/magento-lts/blob/1.9.4.x/app/code/core/Mage/Paypal/etc/config.xml#L195

[schmengler]

BTW, this is an optional field and contains a "partner attribution ID" from PayPal. So as long as OpenMage is not partnering with PayPal, it's safe to remove entirely

https://developer.paypal.com/docs/subscriptions/reference/customize-the-sdk/?mark=bn%20code#partner-attribution-id

[tmotyl]

@schmengler do you know if it can be changed on our side to different value, or does the value has to be approved by paypal first?
I imagine that it would be beneficial to change the value, so paypal can see how many transactions are going through openmage.

[schmengler]

I assume that if you change it to an arbitrary value it will just be ignored. If OpenMage partners with PayPal, PayPal will assign an ID. Then the numbers are interesting for them.

[Flyingmana]

What I wonder, if we put an own value in there which is not a partner, will they still let the payments through and just ignore it? Could someone try this out?
Till then I would say, we remove the ->setData('BNCODE', $bnCode) https://github.com/OpenMage/magento-lts/search?q=bncode&unscoped_q=bncode

personally I would like to add one, even if we are not an official partner, just to set a sign of how many people are using it.

[Flyingmana]

Maybe we can also extract the module, and business entity would like to apply as partner via https://www.paypal.com/lu/webapps/mpp/partner-programme in return for officially maintaining the module.

[richardferaro]

The BN code can be any value as long as the maintainer of the module is a recognized PayPal Partner. The value is passed along within PayPal ecosystem and it is known internally as Partner Attribution ID. Although this optional, it does add value being a known partner in the gateway community.

[colinmollenhour]

I don't think any of us want to create a PayPal business account right now.. EDIT: re-read the thread.. Looks like we should just remove it unless/until we become a PayPal Partner.

[rvelhote]

What I wonder, if we put an own value in there which is not a partner, will they still let the payments through and just ignore it? Could someone try this out?
Till then I would say, we remove the ->setData('BNCODE', $bnCode) https://github.com/OpenMage/magento-lts/search?q=bncode&unscoped_q=bncode

I added a breakpoint to the method where internal configuration setting is invoked and also to those ->setData('BNCODE', $bnCode). I also forced the setting to return null and detected no side-effects.

This might be store specific however the BNCODE setting was only used to set a parameter called BUTTONSOURCE and the breakpoints I added to the two references of ->setData('BNCODE', $bnCode) were never hit.