Magento-lts: Would it be an idea to add a release # or some kind of v number here?

Created on 16 Jan 2020  Â·  10Comments  Â·  Source: OpenMage/magento-lts

Would it be an idea to add a release # or some kind of v number here?

image

Most helpful comment

@sreichel we have the Version number available in the Mage Class.

We need to add the usage on several places then analog to how Magento is doing it till now.
https://github.com/OpenMage/magento-lts/search?q=%22Mage%3A%3AgetVersion%28%29%22&unscoped_q=%22Mage%3A%3AgetVersion%28%29%22
We should also think of removing the Magento Version at one point in the templates, but thats maybe another ticket then.

All 10 comments

Yes, it would be a good idea.
I think also stating there its OpenMage would be a good idea.

But thats a very heavy visible change, so we should start an RFC about how this should look, and maybe how strong and in which way we want to signalize we are OpenMage, and a fork of Magento

i meant only in the backend ; so the admin would know which version he is
on; can also be somewhere else

On Thu, Jan 16, 2020 at 2:22 PM Daniel Fahlke notifications@github.com
wrote:

Yes, it would be a good idea.
I think also stating there its OpenMage would be a good idea.

But thats a very heavy visible change, so we should start an RFC about how
this should look, and maybe how strong and in which way we want to
signalize we are OpenMage, and a fork of Magento

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenMage/magento-lts/issues/881?email_source=notifications&email_token=AAE7I27OLXCZ4OSLGCQSVN3Q6BNQLA5CNFSM4KHTKPYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJEBEGQ#issuecomment-575148570,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE7I277CWXY6G64IDDHGRDQ6BNQLANCNFSM4KHTKPYA
.

even for the Admin area this could be relevant, Iam not sure how the Agencies or rather their customers could react to this, so I want to have some more people approving it

Lets give it some time like 2 weeks or so ;)

Its not a biggy is it?

On Thu, Jan 16, 2020 at 4:38 PM Daniel Fahlke notifications@github.com
wrote:

even for the Admin area this could be relevant, Iam not sure how the
Agencies or rather their customers could react to this, so I want to have
some more people approving it

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenMage/magento-lts/issues/881?email_source=notifications&email_token=AAE7I2Z7EEYJITJDLIJ3OVTQ6B5QXA5CNFSM4KHTKPYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJEP6DA#issuecomment-575209228,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE7I2YHNIKMEVR3AOKAU7DQ6B5QXANCNFSM4KHTKPYA
.

I would welcome it if at least the Version info would show that we ware on OpenMage. At least my customers are irritated that they pay for the migration to OpenMage without a visible sing of it.

even for the Admin area this could be relevant, Iam not sure how the Agencies or rather their customers could react to this, so I want to have some more people approving it

I see only PROs here.

For agencies it's up to them (or their customers) to use official releases or this one.

IMHO ... show official version and LTS release number like ...

_"Magento 1.9.4.5 (LTS 19.4.2)"_

@Flyingmana how about add release version as XML node?

I agree it could be good to show both versions. To me using 19.x.x is really confusing though because it looks confusing against the 1.9.x.x.. Why not just start LTS versioning at 1.0.0 (and maybe back-date and increment them based on past releases)?

With all the code fixes and merges, _magento-lts_ isn't the same as the official code base. So, I think it should have its own identity, something like _Mage-LTS ver a.b.c.d (Magento ver 1.9.4.5)_.

I think we should state both MageLTS name and version as well as which magento version it's based on.

@sreichel we have the Version number available in the Mage Class.

We need to add the usage on several places then analog to how Magento is doing it till now.
https://github.com/OpenMage/magento-lts/search?q=%22Mage%3A%3AgetVersion%28%29%22&unscoped_q=%22Mage%3A%3AgetVersion%28%29%22
We should also think of removing the Magento Version at one point in the templates, but thats maybe another ticket then.

Was this page helpful?
0 / 5 - 0 ratings