Magento-lts: Add option to enable/disable cart merge on login

[seansan]

Add option to enable/disable cart merge on login

We ended up adding this code. Customers just dont understand why when they go to checkout with 3 items in the cart suddenly have 7 (4 others from previous login). So the cart merge on login should really be an option: code can be found here

https://github.com/jacquesbh/jbh_cartmerge

[jacquesbh]

Can we just add a require line in the composer.json?

I mean, if it does the job…

Let me know.

[infabo]

@seansan Quite nice option/feature. Is this the kick-off to a full-blown magento super-package? I mean, installing the extension on demand - this would be enough for me. just my 4 cents.

[jacquesbh]

Maybe we can just add a recommended package in the composer.json?

[LeeSaferite]

Honestly, while I see the point being made, I think that addressing this via a modification to the composer.json file is not correct. But then again, I also think we should be going the opposite direction and stripping lots of things out of the core. I'll abstain from voting one way or the other on this and let the other team members sort it out.

@drobinson @colinmollenhour @Flyingmana

[Flyingmana]

Thats an interesting "Problem" to solve. But I would preffer to not change it (now).
But there is sure space for a "recommended" meta package of must have extensions, or at least some wiki/website page

[colinmollenhour]

I'd consider this a borderline feature and since the upstream is still somewhat active I'm concerned that making too many of such changes could cause merging upstream changes to become increasingly difficult to the point that nobody wants to do it. So to me if the PR can be done in such a way to just add a couple lines of code like:

if (Mage::getStoreConfigFlag('...')) {
    return;
}

and the current behavior continues to be the default, then I wouldn't be opposed.

I am opposed to adding third party modules to composer.json for various reasons.

[jacquesbh]

I would love to read these reasons! (@jacquesbh on twitter if you want to
DM)

Yes ok, I'll consider taking time to make a PR with conditions without
changing the default behavior.

Jacques Bodin-Hullin

--
Monsieur Biz https://monsieurbiz.com
@jacquesbh https://twitter.com/jacquesbh
[phone]
GPG : https://keybase.io/jacquesbh

🦄

Le ven. 10 févr. 2017 à 18:10, Colin Mollenhour [e-mail]
a écrit :

I'd consider this a borderline feature and since the upstream is still
somewhat active I'm concerned that making too many of such changes could
cause merging upstream changes to become increasingly difficult to the
point that nobody wants to do it. So to me if the PR can be done in such a
way to just add a couple lines of code like:

if (Mage::getStoreConfigFlag('...')) {
return;
}

and the current behavior continues to be the default, then I wouldn't be
opposed.

I am opposed to adding third party modules to composer.json for various
reasons.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/OpenMage/magento-lts/issues/168#issuecomment-279002859,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0Z84GljWIHiqPksWwU84V-adF4mpFZks5rbJoUgaJpZM4L74iG
.

[ghost]

Just to put my 2 cents here as I also hate the cart merging: I had written some code that also puts the old items into the wishlist which is nice for the customer. The benefit of making this a module instead of core fix is that we could add that feature if it is needed by others.

[tomekjordan]

HI. I don;t know buy you should consider things like abandoned carts marketing. if you move cart quote to wishlist all 3rd party extensions for abandoned carts will stop doing their job....

[jacquesbh]

Hum, no, because this feature does the move only if the customer adds
something else in its cart.
Infinite loop in real life.

Jacques Bodin-Hullin

--
Monsieur Biz https://monsieurbiz.com
@jacquesbh https://twitter.com/jacquesbh
[phone]
GPG : https://keybase.io/jacquesbh

🦄

Le mer. 15 févr. 2017 à 09:15, Tomek [e-mail] a écrit :

HI. I don;t know buy you should consider things like abandoned carts
marketing. if you move cart quote to wishlist all 3rd party extensions for
abandoned carts will stop doing their job....

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenMage/magento-lts/issues/168#issuecomment-279944747,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0Z80l71lIHqcsLlXrKztwVjAkLzlfhks5rcrQRgaJpZM4L74iG
.

[Flyingmana]

there are obviously different opinions how to handle this.
Regarding of maintenance I decline to merge this and suggest to work on a "must have meta-package" in a separate repository/project

[seansan]

Aren't we making this too complex? I agree with colinmollenhour: if we can make this only a couple lines of extra code then what is the problem?