Mage: KHM - Kaldheim Set Card Implementation Tracking

[theelk801]

Mark cards you're working on in the second post of this issue.
If you can't check things off, leave a comment instead.
Once the card is committed, check off the card here to show that it's finished.
Don't worry about adding new spoilers to this list, it's generated by a script.

All Sets

Unimplemented Cards

Implemented Cards

Click to expand

• [x] Done -- Absorb Identity
• [x] Done -- Aegar, the Freezing Flame
• [x] Done -- Alpine Meadow
• [x] Done -- Alrund's Epiphany
• [x] Done -- Alrund, God of the Cosmos
• [x] Done -- Annul
• [x] Done -- Arachnoform
• [x] Done -- Arctic Treeline
• [x] Done -- Armed and Armored
• [x] Done -- Arni Brokenbrow
• [x] Done -- Arni Slays the Troll
• [x] Done -- Ascendant Spirit
• [x] Done -- Ascent of the Worthy
• [x] Done -- Augury Raven
• [x] Done -- Avalanche Caller
• [x] Done -- Axgard Armory
• [x] Done -- Axgard Braggart
• [x] Done -- Axgard Cavalry
• [x] Done -- Barkchannel Pathway
• [x] Done -- Basalt Ravager
• [x] Done -- Battershield Warrior
• [x] Done -- Battle Mammoth
• [x] Done -- Battle for Bretagard
• [x] Done -- Battle of Frost and Fire
• [x] Done -- Battlefield Raptor
• [x] Done -- Bearded Axe
• [x] Done -- Behold the Multiverse
• [x] Done -- Berg Strider
• [x] Done -- Beskir Shieldmate
• [x] Done -- Bind the Monster
• [x] Done -- Binding the Old Gods
• [x] Done -- Birgi, God of Storytelling
• [x] Done -- Blessing of Frost
• [x] Done -- Blightstep Pathway
• [x] Done -- Blizzard Brawl
• [x] Done -- Blood on the Snow
• [x] Done -- Bloodline Pretender
• [x] Done -- Bloodsky Berserker
• [x] Done -- Boreal Outrider
• [x] Done -- Bound in Gold
• [x] Done -- Breakneck Berserker
• [x] Done -- Bretagard Stronghold
• [x] Done -- Brinebarrow Intruder
• [x] Done -- Broken Wings
• [x] Done -- Burning-Rune Demon
• [x] Done -- Calamity Bearer
• [x] Done -- Canopy Tactician
• [x] Done -- Cinderheart Giant
• [x] Done -- Clarion Spirit
• [x] Done -- Cleaving Reaper
• [x] Done -- Codespell Cleric
• [x] Done -- Colossal Plow
• [x] Done -- Cosima, God of the Voyage
• [x] Done -- Cosmos Charger
• [x] Done -- Cosmos Elixir
• [x] Done -- Craven Hulk
• [x] Done -- Crippling Fear
• [x] Done -- Crush the Weak
• [x] Done -- Cyclone Summoner
• [x] Done -- Darkbore Pathway
• [x] Done -- Deathknell Berserker
• [x] Done -- Demon Bolt
• [x] Done -- Demonic Gifts
• [x] Done -- Depart the Realm
• [x] Done -- Disdainful Stroke
• [x] Done -- Divine Gambit
• [x] Done -- Dogged Pursuit
• [x] Done -- Doomskar Oracle
• [x] Done -- Doomskar Titan
• [x] Done -- Doomskar
• [x] Done -- Dragonkin Berserker
• [x] Done -- Draugr Necromancer
• [x] Done -- Draugr Recruiter
• [x] Done -- Draugr Thought-Thief
• [x] Done -- Draugr's Helm
• [x] Done -- Dread Rider
• [x] Done -- Dream Devourer
• [x] Done -- Dual Strike
• [x] Done -- Duskwielder
• [x] Done -- Dwarven Hammer
• [x] Done -- Dwarven Reinforcements
• [x] Done -- Egon, God of Death
• [x] Done -- Elderfang Disciple
• [x] Done -- Elderfang Ritualist
• [x] Done -- Elderleaf Mentor
• [x] Done -- Elven Ambush
• [x] Done -- Elven Bow
• [x] Done -- Elvish Warmaster
• [x] Done -- Eradicator Valkyrie
• [x] Done -- Esika's Chariot
• [x] Done -- Esika, God of the Tree
• [x] Done -- Faceless Haven
• [x] Done -- Fall of the Impostor
• [x] Done -- Fearless Liberator
• [x] Done -- Fearless Pup
• [x] Done -- Feed the Serpent
• [x] Done -- Fire Giant's Fury
• [x] Done -- Firja's Retribution
• [x] Done -- Firja, Judge of Valor
• [x] Done -- Forging the Tyrite Sword
• [x] Done -- Frenzied Raider
• [x] Done -- Frost Augur
• [x] Done -- Frost Bite
• [x] Done -- Frostpeak Yeti
• [x] Done -- Frostpyre Arcanist
• [x] Done -- Funeral Longboat
• [x] Done -- Fynn, the Fangbearer
• [x] Done -- Gates of Istfell
• [x] Done -- Giant Ox
• [x] Done -- Giant's Amulet
• [x] Done -- Giant's Grasp
• [x] Done -- Gilded Assault Cart
• [x] Done -- Glacial Floodplain
• [x] Done -- Gladewalker Ritualist
• [x] Done -- Glimpse the Cosmos
• [x] Done -- Glittering Frost
• [x] Done -- Glorious Protector
• [x] Done -- Gnottvold Recluse
• [x] Done -- Gnottvold Slumbermound
• [x] Done -- Gods' Hall Guardian
• [x] Done -- Goldmaw Champion
• [x] Done -- Goldspan Dragon
• [x] Done -- Goldvein Pick
• [x] Done -- Graven Lore
• [x] Done -- Great Hall of Starnheim
• [x] Done -- Grim Draugr
• [x] Done -- Grizzled Outrider
• [x] Done -- Guardian Gladewalker
• [x] Done -- Hagi Mob
• [x] Done -- Hailstorm Valkyrie
• [x] Done -- Halvar, God of Battle
• [x] Done -- Harald Unites the Elves
• [x] Done -- Harald, King of Skemfar
• [x] Done -- Haunting Voyage
• [x] Done -- Hengegate Pathway
• [x] Done -- Highland Forest
• [x] Done -- Horizon Seeker
• [x] Done -- Ice Tunnel
• [x] Done -- Icebind Pillar
• [x] Done -- Icebreaker Kraken
• [x] Done -- Icehide Troll
• [x] Done -- Immersturm Predator
• [x] Done -- Immersturm Raider
• [x] Done -- Immersturm Skullcairn
• [x] Done -- In Search of Greatness
• [x] Done -- Infernal Pet
• [x] Done -- Inga Rune-Eyes
• [x] Done -- Invasion of the Giants
• [x] Done -- Invoke the Divine
• [x] Done -- Iron Verdict
• [x] Done -- Jarl of the Forsaken
• [x] Done -- Jaspera Sentinel
• [x] Done -- Jorn, God of Winter
• [x] Done -- Kardur's Vicious Return
• [x] Done -- Kardur, Doomscourge
• [x] Done -- Karfell Harbinger
• [x] Done -- Karfell Kennel-Master
• [x] Done -- Kaya the Inexorable
• [x] Done -- Kaya's Onslaught
• [x] Done -- King Harald's Revenge
• [x] Done -- King Narfi's Betrayal
• [x] Done -- Koll, the Forgemaster
• [x] Done -- Kolvori, God of Kinship
• [x] Done -- Koma's Faithful
• [x] Done -- Koma, Cosmos Serpent
• [x] Done -- Littjara Glade-Warden
• [x] Done -- Littjara Kinseekers
• [x] Done -- Littjara Mirrorlake
• [x] Done -- Magda, Brazen Outlaw
• [x] Done -- Maja, Bretagard Protector
• [x] Done -- Mammoth Growth
• [x] Done -- Masked Vandal
• [x] Done -- Maskwood Nexus
• [x] Done -- Master Skald
• [x] Done -- Mists of Littjara
• [x] Done -- Mistwalker
• [x] Done -- Moritte of the Frost
• [x] Done -- Mystic Reflection
• [x] Done -- Narfi, Betrayer King
• [x] Done -- Niko Aris
• [x] Done -- Niko Defies Destiny
• [x] Done -- Old-Growth Troll
• [x] Done -- Open the Omenpaths
• [x] Done -- Orvar, the All-Form
• [x] Done -- Path to the World Tree
• [x] Done -- Pilfering Hawk
• [x] Done -- Poison the Cup
• [x] Done -- Port of Karfell
• [x] Done -- Priest of the Haunted Edge
• [x] Done -- Provoke the Trolls
• [x] Done -- Pyre of Heroes
• [x] Done -- Quakebringer
• [x] Done -- Raiders' Karve
• [x] Done -- Raise the Draugr
• [x] Done -- Rally the Ranks
• [x] Done -- Rampage of the Valkyries
• [x] Done -- Raven Wings
• [x] Done -- Ravenform
• [x] Done -- Ravenous Lindwurm
• [x] Done -- Realmwalker
• [x] Done -- Reckless Crew
• [x] Done -- Reflections of Littjara
• [x] Done -- Reidane, God of the Worthy
• [x] Done -- Renegade Reaper
• [x] Done -- Replicating Ring
• [x] Done -- Resplendent Marshal
• [x] Done -- Return Upon the Tide
• [x] Done -- Revitalize
• [x] Done -- Righteous Valkyrie
• [x] Done -- Rimewood Falls
• [x] Done -- Rise of the Dread Marn
• [x] Done -- Rootless Yew
• [x] Done -- Roots of Wisdom
• [x] Done -- Run Amok
• [x] Done -- Run Ashore
• [x] Done -- Rune of Flight
• [x] Done -- Rune of Might
• [x] Done -- Rune of Mortality
• [x] Done -- Rune of Speed
• [x] Done -- Rune of Sustenance
• [x] Done -- Runed Crown
• [x] Done -- Runeforge Champion
• [x] Done -- Sarulf's Packmate
• [x] Done -- Sarulf, Realm Eater
• [x] Done -- Saw It Coming
• [x] Done -- Scorn Effigy
• [x] Done -- Sculptor of Winter
• [x] Done -- Search for Glory
• [x] Done -- Seize the Spoils
• [x] Done -- Shackles of Treachery
• [x] Done -- Shepherd of the Cosmos
• [x] Done -- Shimmerdrift Vale
• [x] Done -- Showdown of the Skalds
• [x] Done -- Sigrid, God-Favored
• [x] Done -- Skemfar Avenger
• [x] Done -- Skemfar Elderhall
• [x] Done -- Skemfar Shadowsage
• [x] Done -- Skull Raid
• [x] Done -- Smashing Success
• [x] Done -- Snakeskin Veil
• [x] Done -- Snow-Covered Forest
• [x] Done -- Snow-Covered Island
• [x] Done -- Snow-Covered Mountain
• [x] Done -- Snow-Covered Plains
• [x] Done -- Snow-Covered Swamp
• [x] Done -- Snowfield Sinkhole
• [x] Done -- Spectral Steel
• [x] Done -- Spirit of the Aldergard
• [x] Done -- Squash
• [x] Done -- Stalwart Valkyrie
• [x] Done -- Starnheim Aspirant
• [x] Done -- Starnheim Courser
• [x] Done -- Starnheim Unleashed
• [x] Done -- Story Seeker
• [x] Done -- Strategic Planning
• [x] Done -- Struggle for Skemfar
• [x] Done -- Sulfurous Mire
• [x] Done -- Surtland Elementalist
• [x] Done -- Surtland Flinger
• [x] Done -- Surtland Frostpyre
• [x] Done -- Svella, Ice Shaper
• [x] Done -- Tergrid's Shadow
• [x] Done -- Tergrid, God of Fright
• [x] Done -- The Bears of Littjara
• [x] Done -- The Bloodsky Massacre
• [x] Done -- The Raven's Warning
• [x] Done -- The Three Seasons
• [x] Done -- The Trickster-God's Heist
• [x] Done -- The World Tree
• [x] Done -- Thornmantle Striker
• [x] Done -- Tibalt's Trickery
• [x] Done -- Toralf, God of Fury
• [x] Done -- Tormentor's Helm
• [x] Done -- Toski, Bearer of Secrets
• [x] Done -- Tundra Fumarole
• [x] Done -- Tuskeri Firewalker
• [x] Done -- Tyrite Sanctum
• [x] Done -- Tyvar Kell
• [x] Done -- Undersea Invader
• [x] Done -- Usher of the Fallen
• [x] Done -- Valki, God of Lies
• [x] Done -- Valkyrie Harbinger
• [x] Done -- Valkyrie's Sword
• [x] Done -- Valor of the Worthy
• [x] Done -- Varragoth, Bloodsky Sire
• [x] Done -- Vault Robber
• [x] Done -- Vega, the Watcher
• [x] Done -- Vengeful Reaper
• [x] Done -- Village Rites
• [x] Done -- Volatile Fjord
• [x] Done -- Vorinclex, Monstrous Raider
• [x] Done -- Waking the Trolls
• [x] Done -- Warchanter Skald
• [x] Done -- Warhorn Blast
• [x] Done -- Weathered Runestone
• [x] Done -- Weigh Down
• [x] Done -- Wings of the Cosmos
• [x] Done -- Withercrown
• [x] Done -- Woodland Chasm
• [x] Done -- Youthful Valkyrie
  

[theelk801]

All cards have been implemented.

[theelk801]

• [x] [Vorinclex, Monstrous Raider](https://scryfall.com/card/khm/199/vorinclex-monstrous-raider) needs refactoring of counter-adding methods to track which player is adding the counters
• [x] Implement Foretell ability
  -- Exiling the card is a special action
  -- Need to track what turn it is, show both players whether it was exiled this turn
• [x] Update snow mana implementation to allow for counting how much was spent (needed for many of the snow sorceries)
• [x] Implement snow land collation, making sure that snow basics and snow dual show up in the land slot in the correct ratio
• [x] Fix how counters are displayed on MDFCs that aren't on the battlefield

[weirddan455]

I'd like to help with this if you don't mind (or does your second post mean you're already working on all these cards?) I don't think I have permissions to check stuff off on the list but I'm about to send a pull request for Absorb Identity.

[theelk801]

Totally, feel free to contribute. I’ve been busy so I haven’t really gotten into these yet.

[weirddan455]

I'm taking Fire Giant's Fury next (saw the list updating so wanted to make sure we're not taking the same cards.)

[theelk801]

Yeah, no problem. The help is much appreciated.

[weirddan455]

I'll take Thornmantle Striker unless you want it.

[theelk801]

It's all yours.

[weirddan455]

Lots of new cards spoiled today. Is there a script we can run to fetch the card data so Utils/gen-card.pl will work for them?

I also just sent a PR implementing the Boast mechanic as a common ability class so that we can use that for the new cards.

[theelk801]

I have a personal script I use but I'm waiting on scryfall to update with all the new stuff. Usually I don't implement a new mechanic until I'm implementing a card that uses it.

[weirddan455]

I'm planning on implementing Varragoth, Bloodsky Sire which uses Boast. I just don't know the formatting for Utils/mtg-cards-data.txt which is why I was asking about a script. I guess it's probably best to wait on scryfall?

[theelk801]

If you want to implement it now you can, but scryfall should be caught up by the end of the day. The formatting is like this:

Card Name|Set Name (Full)|Collector Number|Rarity (C/U/R/M)|Mana Cost|Type Line|Power|Toughness|Rules text with $ denoting line breaks|

If it's a planeswalker then replace |Power|Toughness| with |Loyalty|. Also don't worry about having multiple versions, those will get added later.

[weirddan455]

Thanks. I've got it implemented now. I'll do the snow duals too.

[ciaccona007]

Just implemented Sigrid. I'm no expert on git so before I merge the PR I was wondering which procedure you guys prefer when merging them (squash & merge, rebase, merge commit).

[weirddan455]

I'm going to take Calamity Bearer.

[JayDi85]

@ciaccona007 depends on PR's commits:

• If it contains a good commits for change history (one commit per feature or fix) then use merge;
• If it contains a multiple commits like "merge", "fix type", "fix another type", "forget something" then use squash with good description;
• If you want to put old commits on the top (if other devs must read it) then you can use rebase (example: old PR with important changes). Another use case: if you have a local commits and want to sync sources -- then use rebase update instead merge (IntelliJ IDEA have an easy to use settings for that);

P.S. If you want PR's review then don't merge it -- wait a new review from another dev. If you ensure about fix or card then you can add it to master without PR.

[weirddan455]

Taking Esika, God of the Tree next.

[weirddan455]

Taking Koll, the Forgemaster.

[weirddan455]

I've got Tyvar Kell mostly done. I'm just missing the haste ability on the emblem which is worded strangely. Just from a Magic rules perspective, I'm not sure how giving an Elf on the stack haste makes sense.

I'm thinking I may have to give the emblem a static ability so it can give haste once the Elf has actually entered the battlefield (after checking that it was cast) but if anyone has a better idea, let me know.

I'll take another look at it tomorrow and try to get it working.

[theelk801]

You can probably generate a continuous effect that applies to it on the stack and on the battlefield, you just need to check two possible zone change counter values.

[weirddan455]

I'll take Kolvori, God of Kinship.

[jeffwadsworth]

CosimaGodOfTheVoyage.zip
Withercrown
https://github.com/magefree/mage/commit/708a486eb65213d5f851bf3aa49222edd19a86e4

Wings of the Cosmos
https://github.com/magefree/mage/commit/72c4369899d8ad3fbcf2c5c75649f7087259c143

Valki, God of Lies
Done

Tergrid, God of Fright
Done

Alrund, God of the Cosmos
Done

Valor of the Worthy
Done

Foretell keyword ability.
Implemented. Please check for any bugs yet again in the new update.

Cosmos Charger -> The cost reduction is easy, but perhaps someone knows of a way to set the ActivationStatus to True on the Special Action of Foretelling.

Cosima, God of the Voyage : I put the current code for the card. I have moved on. If anyone can fix it, please have at it.

Dream Devourer: Working on this now.

[weirddan455]

I'll take Battle of Frost and Fire.

[weirddan455]

Taking Draugr's Helm next.

[weirddan455]

I'm taking Firja's Retribution.

[weirddan455]

@jeffwadsworth You probably need to clear the database if cards don't show up. I have a script that deletes the Mage.Client/db and Mage.Server/db folders that I run before I test a new card.

[JayDi85]

@weirddan455 server/client/tests runs a new cards checking on startup, so it will auto-add new card to database. DB cleaning can be useful only for manual checking after a text changing in existing card.

More tips:

• If you want to check actual card text then run a unit test VerifyCardDataTest->test_showCardInfo -- it's very fast and don't use db, so you can see actual card's info all the time;
• If you want to speed up a unit tests start up time then disable new cards checking by FAST_SCAN_WITHOUT_DATABASE_CREATE param (search it in code);

[theelk801]

Yeah it's good to write unit tests whenever you can, even though I don't do it nearly enough.

[theelk801]

@jeffwadsworth you should be able to use the same code as Leonin Shikari for Cosmos Charger.

[jeffwadsworth]

@jeffwadsworth you should be able to use the same code as Leonin Shikari for Cosmos Charger.

Sadly, that doesn't work either. It doesn't affect the ActivationStatus.

[weirddan455]

Just saw you pushed the snow land collation. Is there something we need to do to enable booster draft for the set seeing as it's mostly complete now?

[theelk801]

I don't think so but I don't actually know for sure

[weirddan455]

@theelk801 OK, it seems to be working now. I thought I had tried it a week or 2 ago and KHM packs weren't an option but maybe I just missed it.

[theelk801]

I'll take Cosima

[theelk801]

Thanks to everyone who helped get this done.

[JayDi85]

Visibility of MDF card's counters was fixed in c381ea77168c382c365de197d670aae7051b9ba4 (Cosima, God of the Voyage), so it can be closed.