Macvim: Rows of text seem clipped at certain font sizes on Catalina

[twk]

Running 8.1.950 on Catalina, when I start MacVim, some lowercase letters are getting clipped:

If I adjust the font size and then adjust it back, things are rendered correctly:

This started as soon as I upgraded to Catalina -- Mojave was fine. My font settings are English/Menlo/Regular/11

[ychin]

I will need to see if I can repro this under the new Xcode. Otherwise could be tricky as I don't have a beta Catalina install with me.

[AdamJacobMuller]

Happens for me after upgrading to catalina, but, only with Core Text renderer enabled.

With Core Text renderer disabled things are actually considerably worse.

actual:

[eirnym]

I'd wait for first public beta. Before that point macOS is not really usable at all

[AdamJacobMuller]

Aside from the MacVim issue my workflow is fine and I've just been running vim instead.

[eirnym]

I'm really surprised to read it! This release will be the first one with relatively stable betas, since it wasn't a case since macOS 10.7 Beta 1

[eirnym]

Public Beta is out…

[eirnym]

It's interesting, I can reproduce it with

guifont=Menlo-Regular:h11, but not with guifont=Fira\ Code\ Light:h12

[jjgod]

This is a duplicate of #883.

[jjgod]

Oh, @eirnym, it's because the comparison sees that the new font Menlo-Regular:h11 is the same as the default font initialized by -[MMCoreTextView initWithFrame:] and skip rest of the initialization:

if (!(newFont && font != newFont))
    return;

That's why in this case fontDescent is still properly initialized.

[jjgod]

(lldb) p font
(NSCTFont *) $0 = 0x0000000101c233e0
(lldb) p newFont
(NSCTFont *) $1 = 0x0000000101c233e0
(lldb) po font
"Menlo-Regular 11.00 pt. P [] (0x101c28300) fobj=0x101c233e0, spc=6.62"

(lldb) po newFont
"Menlo-Regular 11.00 pt. P [] (0x101a00860) fobj=0x101c233e0, spc=6.62"

[eirnym]

I've tried it after Fira Code, to guarantee that it's a different one

[jjgod]

That's why you are not hitting the problem with Fira Code.

[eirnym]

and what's about Menlo?

I've set Fira Code first, then Menlo, and issue still exists. This doesn't neglect your issue on fontDescent, though. Probably, in macOS Catalina this parameter becomes more valuable to set if it's not.

[jjgod]

How exactly did you do that? Did you execute multiple set guifont command?

[ychin]

I think this should now be fixed and will be released in the next update. If someone wants to confirm (I haven't installed the beta macOS yet) that would be great.

[eirnym]

I'll test it today

[AdamJacobMuller]

i'm happy to test but i don't particularly want to build this myself and it seems like the last release was 157, any chance of 158 being released to test?

[tobireif]

I just installed MacOS Catalina (version "10.15 (19A583)"). Now I get this issue:

The test-text: Qq Gg Yy
MacVim version "Custom Version 8.1.1722 (157)".
This is a severe issue. I hope it can get fixed soon.
:set guifont? says Menlo.

[securitygeneration]

I'm also surprised this wasn't fixed/released prior to Catalina's release.

[eirnym]

@securitygeneration This is an open source project. You could do a contribution of your time and knowledge.

[securitygeneration]

@eirnym I was following this and saw that it seemed to be tentatively resolved (https://github.com/macvim-dev/macvim/issues/905#issuecomment-516080155), and so it didn't seem to need any additional attention (although yes, I could've tried to test it). ¯\_(ツ)_/¯

[ychin]

Next update will be out this weekend.

[hoke-t]

Any updates on this?

[isaki]

As per @eirnym, I am posting this here and closing my issue.

I can confirm this is still an issue after the weekend.

I am running the latest release:

And can confirm fonts still look strange:

And that the changing the font size back and forth fixes things:

My macOS version:

% sw_vers 
ProductName:    Mac OS X
ProductVersion: 10.15
BuildVersion:   19A583

[eirnym]

@isaki Thank you for an addition, Please, write which distribution of MacVim do you use (e.g. GitHub, Homebrew, MacPorts, etc) and which font are you using (:set guifont?)

[tobireif]

changing the font size back and forth fixes things

Here it fixes it temporarily for that one buffer/window, but not permanently.

(I'm using the distribution from https://github.com/macvim-dev/macvim/releases plus auto-updates.)

:set guifont? says guifont=Menlo:h16

[hoke-t]

I have the exact issue as well. I always have to increase and then decrease the font size upon opening a file to fix the clipping.

Using macOS 10.15 build version 19A583, Homebrew distribution of MacVim, and set guifont? gives guifont=Menlo-Regular:h11.

[isaki]

@eirnym I am using the GitHub distribution of MacVim.

I apparently have no font set once so ever:

Also, commands are also being chopped off:

Finally, this is the font setup that seems to be in use when I run set guifont=*:

I hope this information helps!

[eirnym]

Thank you, this is fixed in HEAD. So I hope @ychin will find the time to prepare a release.

[jimsiff]

Thank you @eirnym and @ychin. It's fixed for me after building 8.1.2102 on Catalina.

[ychin]

This should be fixed in snapshot-159. Let me know if it isn't.

[isaki]

This has indeed fixed it, thank you!

[hoke-t]

Can confirm as well. Thanks!