Macvim: Why does brew version of macvim looks different in tab bar appearance?

[clavichord93]

I used to use brew version of macvim and now switch to this origin version, but I found these two looks different in tab bar. Brew version looks in a more post Yosemite style but this origin version looks in a Mavericks style. Why does this happen?

[splhack]

please clarify the versions. what is "brew version of macvim"? "this origin version"?

[clavichord93]

both are 7.4-106.
brew version is installed with brew install macvim.
origin version is downloaded from github with MacVim.dmg.

[sfcgeorge]

I've also noticed this. I installed via Brew but it also keeps auto updating and so the tab styles change. "About" menu shows I'm on the latest version even though I'm seeing old style tabs.

[amw]

@splhack In case you are wondering what we're talking about. Here are tab bars from macvim-dev releases stream:

And here are tab bars when compiling MacVim through Homebrew:

[sfcgeorge]

My hunch is build machine. I'm guessing there's a compile time flag that detects the OS version being compiled on and sets the tab style accordingly. The Homebrew version is always compiled on your machine, so you get the new tabs. The release version is pre-compiled so you get the tabs of the build machine.

[splhack]

I'll change MAC_OS_X_VERSION_MIN_REQUIRED check to NSAppKitVersionNumber runtime version check for the tab bar style.

[rappazzo]

I find the new tabbar style hideous. Can I request a config setting for the former style? Pretty please? Or is the old style deprecated in OSX/MacOS?

[amw]

This new style is nothing like native macOS tabs. Some issues not present in apps like Safari/Finder/Pages:

1. Tab bar only holds a small, finite number of tabs. Additional tabs go into a hidden list – even the currently active tab.
2. The icons for new tab and that expansion list are custom-made and poorly aligned.

[sfcgeorge]

There wasn’t previously an official OS X tab widget, apps like MacVim did their best to copy. Now their is an official way of doing tabs (that MacVim doesn’t use yet) that looks like the new style. So the new style is consistent across Apple apps and increasingly 3rd party apps. I’m in favour of keeping it the new way, rather than going down the rabbit hole of config for every little thing. Though the new style doesn’t quite match the true Apple tabs, the colours are too light, but that could be fixed.

On 24 Oct 2016, at 13:09, Michael Rappazzo [email protected] wrote:

I find the new tabbar style hideous. Can I request a config setting for the former style? Pretty please? Or is the old style deprecated in OSX/MacOS?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/macvim-dev/macvim/issues/329#issuecomment-255722823, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2BC9UDFBBkJ3QgnhUFCgO3zuqhRkEKks5q3KAHgaJpZM4Jne4Z.

[rappazzo]

I am running Mavericks and I see the style in @amw's second image from the comment on Sep 9. That is the offensive looking tab bar. It is also missing the close button on each tab (which seems like a regression).