Lunie: Extension hot reload failing: FILE NOT FOUND

[Bitcoinera]

Probably just some silly webpack bug:

Steps to reproduce:

• build extension locally
• run yarn watch:dev
• make some change in the code and try to open extension again

You will get the above blank screen with the FILE NOT FOUND error.

To fix it you need to rerun yarn watch:dev

[Bitcoinera]

I'm investigating this and seems related to staging-API being down... but I am not sure (cannot obviously confirm as staging API is dead)

[Bitcoinera]

Ah ok, the problem is that after rebuilding when hot reloading it loses the manifest.json. Investigating

[Bitcoinera]

      {
        from: 'manifest.json',
        to: 'manifest.json',
        transform: (content) => {
          const jsonContent = JSON.parse(content)
          jsonContent.version = version

          if (config.mode === 'development') {
            jsonContent['content_security_policy'] =
              "script-src 'self' 'unsafe-eval' https://www.google-analytics.com/analytics.js; object-src 'self'"
          }

          return JSON.stringify(jsonContent, null, 2)
        }
      }

manifest.json gets renames as manifest.js :thinking: We are missing some rule here?

[Bitcoinera]

@mariopino could you reproduce this?

[mariopino]

@mariopino could you reproduce this?

Yep, I'll try to reproduce today

[Bitcoinera]

:eyes:

Did you make any progress here? Should I take this?

[Bitcoinera]

Mmm, trying various things but nothing seems to work. manifest.json always disappears for some reason

It seems like there was already some trouble with this in any case. This chunk of code is to be found in webpack.config.js:

if (process.env.HMR === 'true') {
  config.plugins = (config.plugins || []).concat([
    new ExtensionReloader({
      manifest: resolve('src/manifest.json')
    })
  ])
}

[mariopino]

@mariopino could you reproduce this?

Yep, I'll try to reproduce today

Sorry to be late but yep, it can be reproduced in Windows 10 / Chrome:

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[Bitcoinera]

This got staled and it is a very annoying bug for development. Someone has any idea?

[jbibla]

well, there is something going on with webpack-extension-reloader and HMR.

webpack-extension-reloader doesn't work with HMR:

the docs recommend using __dirname but we are using a static folder.

... not sure!

@faboweb any ideas?

[Bitcoinera]

Mmm, interesting :thinking: Maybe we should rename dist as __dirname?

[jbibla]

no no https://nodejs.org/docs/latest/api/modules.html#modules_dirname