Lunie: Cleaning up notifications

[jbibla]

now

• [x] user menu ghost icon is not centred on windows
• [x] "Add an address" should go in user menu
• [x] CardSignIn should be modal instead of in page component
• [x] paywall variables and scroll bugs
• [x] message after sign in toggles states should be a modal that displays which addresses you'll receive notifications about -> link and CTA should go to notifications page
• [x] voting power changes message is broken (should show %)
• [x] remove new validator notification for now (and use network icon instead of lunie logo - for future use)
• [x] lunie theme on notifications page instead of network theme
• [x] hide app menu - add logo - deselect current network when on notifications page
• [x] notifications becomes home page / landing page if user is signed in with email
• [x] magic link copy needs to be updated
• [x] click the notifications icon from the paywall and the app gets stuck on a loading screen
• [x] take user out from notifications back to Paywall when they sign out being on the notifications page

next

• [ ] connect user emails via intercom
• [ ] drip campaign
• [ ] only display notifications that go back 30 days
• [ ] every user should have 1 notification from Lunie that says welcome

[Bitcoinera]

I like this multi-issue! So much stuff to do! :sunglasses:

[Bitcoinera]

message after sign in toggles states should be a modal that displays which addresses you'll receive notifications about -> link and CTA should go to notifications page

You mean that the email-authentication page should be a modal with these characteristics? Sounds cool

[Bitcoinera]

voting power changes message is broken (should show %)

Seems correct? What do you think is broken?

[jbibla]

increased from 0.214230 to 0.235088 (9.284% increase)

should be

increased from 0.21% to 0.24%

[faboweb]

Remember to do the issues as individual PRs

[Bitcoinera]

Remember to do the issues as individual PRs

But many of these things are super tiny... I would do all of the "now" ones simply in this PR

[Bitcoinera]

Yes, I know what you are about to say: it's a one line change :laughing:

[faboweb]

... I think this will be a lot smoother with multiple PRs

[Bitcoinera]

... I think this will be a lot smoother with multiple PRs

But not 12 PRs?

[jbibla]

bug - the form validation for sign-up-email is not strong enough. the user will see the error message but properly formatted emails will still go through to the API

[jbibla]

we should be using native validation too:

https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation

[Bitcoinera]

we should be using native validation too:

Nice! Let's do it

[Bitcoinera]

Oops, there is one item missing!

• [x] take user out from notifications back to Paywall when they sign out being on the notifications page

[Bitcoinera]

What do you mean in this one hide app menu - add logo - deselect current network when on notifications page when you say "add logo", @jbibla ?

[jbibla]

i'll handle it in my PR - no worries.

[Bitcoinera]

i'll handle it in my PR - no worries.

EDIT: Oh, ok :+1:

Should it look like this?

[jbibla]

yes, but also deselect selected network. i already did this in my PR so please don't add it to your open PR.

[Bitcoinera]

yes, but also deselect selected network. i already did this in my PR so please don't add it to your open PR.

OK. Should I then go for the last item on the list then? This:

"message after sign in toggles states should be a modal that displays which addresses you'll receive notifications about -> link and CTA should go to notifications page"

[jbibla]

you should get your open PRs merged. after that, yes.

[Bitcoinera]

you should get your open PRs merged. after that, yes.

My PRs are just ready to be merged! (Except the two push notifications ones and the night mode one).

This one for example #4481 just needs your styles approval
This last one #4548 you just need to merge it
This one too, just merge #4543

[jbibla]

ok i'll have a look.

what about: https://github.com/luniehq/lunie/pull/4546

[Bitcoinera]

what about: #4546

This one I am trying to fix the validator list E2E error.

But tested manually and validator search works in fact

[Bitcoinera]

what happened? Why did you reopen this one?

[faboweb]

There are 2 items that are not done...

message after sign in toggles states should be a modal that displays which addresses you'll receive notifications about -> link and CTA should go to notifications page

magic link copy needs to be updated

[Bitcoinera]

True, I hadn't forgotten about the last one. Currently email-authentication looks quite ugly, 100% agreed

[faboweb]

Yep, this is mostly about the email-authentication page

[jbibla]

i will do this now