Lunie: Display amount of rewards obtained from reward withdrawal

[fedekunze]

Is your feature request related to a problem? Please describe.

Currently we don't show on the transactions how many tokens you gained when you withdraw rewards.

Describe the solution you'd like

Show the rewards obtained with the withdraw transaction.

Describe alternatives you've considered

Query balance before and after withdrawal and get the difference (short term)
Get the reward coins obtained through Gaia-lite (post-lunch release)

Additional context

cc: @jackzampolin @alexanderbez

[alexanderbez]

This would be super simple once we implement an event-based log system in the sdk (e.g. ctx.Event("delegation_rewards", coins). I'm not sure there is a super clean solution in the short-term.

[jbibla]

post-lunch

🍔

[fedekunze]

This would be super simple once we implement an event-based log system in the sdk (e.g. ctx.Event("delegation_rewards", coins). I'm not sure there is a super clean solution in the short-term.

I think that's too much overhead, we just need to either

• add an amount field to the request withdraw message, or
• return the amount withdrawn by adding it to the response message

[faboweb]

Should this issue move into the SDK?

[alexanderbez]

return the amount withdrawn by adding it to the response message

Seems like the easiest approach. Sure @faboweb.

[faboweb]

This is now possible as the tags on a withdraw tx include the withdraw amount.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[faboweb]

Still relevant

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jbibla]

would be nice to do this still. probably very simple.

[alexanderbez]

This is now emitted in the tx's event logs. Wait till the next major upgrade to use this functionality.

[jbibla]

Wait till the next major upgrade

@alexanderbez do you mean cosmoshub-3?

[alexanderbez]

Yup!

[jbibla]

we can implement on gaia-13k6

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[jbibla]

yes, please. let's do this already!

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[jackzampolin]

This should not be doable fwiw

[jbibla]

yep! definitely, thanks @jackzampolin.

@Bitcoinera @mariopino is this covered with the new tx abstraction work?

[Bitcoinera]

@Bitcoinera @mariopino is this covered with the new tx abstraction work?

Yes, it is. But in multidenom networks we only display the staking denom.

[jbibla]

in multidenom networks we only display the staking denom.

ok for now!

[Bitcoinera]

ok for now!

Cool. This is how it is looking now:

[mariopino]

Related: https://github.com/luniehq/lunie-api/issues/369