Lunie: Handle ledger disconnection before signing

[faboweb]

What happens if the user signs in with ledger and then disconnects before he clicks to sign with ledger?
Should we show an additional note for this?
Is there a bug if this happens?

Scope:

• Check if Ledger is connected when opening ActionModal
• Reconnect if Ledger is not connected

[jbibla]

i don't think we should allow logins with ledger ... it is unnecessary since _signing_ is not actually required for "signing in".

[faboweb]

We get the address of the user from the ledger. I think it is the most efficient way for the user to provide Voyager with his address.

[jbibla]

ahhhhhhhhhhhhhhh. fair enough.

i suppose this is an added convenience. but this should only be needed on the first session per device if we are storing the addresses / accounts in local storage.

---

the ledger should be disconnected after sign in because the connection is not needed until transactions need to be signed. can we disconnect on purpose? users will be able to use the app without "signing in" anyways.

[faboweb]

but this should only be needed on the first session per device if we are storing the addresses / accounts in local storage.

Great idea, but we need to rebuild/redesign sign-in for this.

[jbibla]

on first sign it - it should say: "enter your address here or connect your ledger and we'll set things up for you"

[fedekunze]

The sign with Ledger function on the module assumes that Ledger is connected (it calls the app from the state). We should add check if it throws because Ledger is unplugged and reconnect if so

[faboweb]

Updated scope

[fedekunze]

the part of * Check if Ledger is connected when opening ActionModal can be accomplished by changing the transport communication method with the ledger from comm_u2f to comm_node, but it is failing because of a library dependency error on ledger-cosmos-js. I already contacted Juan to push a fix soon