Lunie: Show worth of vote when voting

[fedekunze]

Description:

Currently the behaviour on the SDK is that if you are a delegator who wants to vote, your vote only counts on the total tally if you have a delegation to a validator.

Consider the following flow:

1) Not yet bonded delegator casts a vote on proposal 1
2) Tally of proposal 1 is still the same
3) delegator submits a delegation to validator
4) Tally of proposal 1 is updated and increased by the delegation amount

This means that on this case, before (or after) the delegator cast a vote , we need to show a message that the vote won't count unless it delegates to a validator before the voting period finishes.

cc: @faboweb @sabau @jbibla @jackzampolin

Scope:

if user doesn't have any delegation:

• [ ] Disable Submit button on VoteModal
• [ ] Add message to delegate first

else

• [ ] add a message on VoteModal about how much the vote is worth

[jackzampolin]

Agree completely! Great improvement.

[jbibla]

do we have to let users vote if they haven't delegated yet?

[fedekunze]

do we have to let users vote if they haven't delegated yet?

I think that's a great question but I think it's more suitable for the SDK team (I also questioned this). I'm just stating the current behaviour here

[jbibla]

my gut says we should just tell users they need to delegate before voting - as opposed to letting them vote and telling them their vote won't count until they do another action. we also have to account for changing the way we show their "uncounted vote" which i'd prefer to avoid.

sometimes, UIs will not directly mimic the SDK to provide a superior UX 😄

[fedekunze]

my gut says we should just tell users they need to delegate before voting - as opposed to letting them vote and telling them their vote won't count until they do another action.

I totally agree. Let's do that

[faboweb]

But we also need to teach the user that their vote changes according to bonding/unbonding

[fedekunze]

But we also need to teach the user that their vote changes according to bonding/unbonding

Sounds something we should add to the Voyager tutorial/walkthrough. Thoughts ?

[faboweb]

Sounds something we should add to the Voyager tutorial/walkthrough.

I would do that on top. I always assume the user is not doing the tutorial ;)

[fedekunze]

@jbibla updated title

[jbibla]

I always assume the user is not doing the tutorial

me too. or at least, they won't fully get it until they try it out.

But we also need to teach the user that their vote changes according to bonding/unbonding

yeah! if a user has votes but undelegates all their stake for some reason ... how will we tell them 😕

[fedekunze]

Do we want to disable the Vote Button on the PageProposal or the submit button on the VoteModal ?
Should we add a tooltip with the message ?

[faboweb]

I still think we shouldn't disable the button but display a message about the worth of this vote. The user wouldn't know that the worth of their votes change later if we just don't allow to vote with 0 delegated atoms. Same goes if we allow them to vote with x delegated atoms and then later they undelegate some votes. We can add another message on the undelegation modal to warn the user that their current votes will change in value.

[jbibla]

later they undelegate some votes

did you mean undelegate some stake / atoms?

I still think we shouldn't disable the button but display a message

my preference would be to disable the button on the modal - but include a message on PageProposal and on ModalPropose ... i think this is a bad ux pattern inherited from the SDK - do we need to emulate it in the UI?

[faboweb]

disable the button on the modal - but include a message on PageProposal and on ModalPropose

ok cool

did you mean undelegate some stake / atoms?

yeah ;)

[fedekunze]

my preference would be to disable the button on the modal - but include a message on PageProposal and on ModalPropose

@jbibla you mean VoteModal instead of ModalPropose?

[jbibla]

ugh, yes. #awaketooearly

although, can you make a proposal if you're not delegated to anyone?

[fedekunze]

although, can you make a proposal if you're not delegated to anyone?

yes you can

[fedekunze]

So from the comments above, the scope should be:

• if user doesn't have any delegation
  
  
  
  • Disable Submit button on VoteModal
  
  
  • if user is signed in, add a message (which one?) on PageProposal (and VoteModal?)
  
  
• else
  
  
  
  • add a message on PageProposal (and VoteModal?) about how much her vote is worth (shouldn't this go on the gov tutorial #1786 @faboweb ?)
  
  

[faboweb]

I would do both. People are not eager to read tutorials from my experience.

[faboweb]

From other ticket:
votes depend on staked atoms
votes change if your staked atoms change
votes only count at the end of the voting period

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.