Lunie: Last commission Change date

[sabau]

Times fly, it seemed few minutes ago.

[jbibla]

🤦‍♂️

[jbibla]

this isn't actually a bug in the JS code. the validator commission update_time being returned is "0001-01-01T00:00:00Z" which is techincally 2018 years ago. so it has something to do with the validator data itself, not the way we are displaying it.

[faboweb]

Did you open an issue on the SDK?

[jbibla]

no not yet. @jackzampolin do you know anything about this?

some context:

• we spin up a local testnet with our yarn start local-testnet command
• this creates a network with 1 validator node
• this validator's commission.update_time is 0001-01-01T00:00:00Z

if we spin it up with more than 1 validator, validator 2 and 3 have expected update_time

[jackzampolin]

@jbibla I have not heard about this. This is in the validator struct returned from which endpoint?

[faboweb]

GET /stake/validators

[jbibla]

i don’t think it’s an issue with the API - my gut tells me it’s just the default property for “the node that starts the network” … any ideas @sabau ?

of course, programming is all about _going with your gut_. :trollface:

[faboweb]

Let's investigate and close again or open an SDK issue.

[jbibla]

i set up a new local testnet with one validator node, then queried with the following command:

gaiacli query staking validator <address>

this returned commission.updateTime: 0001-01-01 00:00:00 which _makes sense_ to me because technically the commission info was never updated. i suppose it could return null or the date of instantiation - but i'm not sure this is an issue.

i made an SDK issue to see what the team thinks: https://github.com/cosmos/cosmos-sdk/issues/3411

in the mean time, i will update the logic in the validator profile page to display something sensible here instead of "2018 years ago" - and we can see what comes of the SDK ticket.

[faboweb]

Awesome. Thx.

Jordan Bibla [e-mail] schrieb am Mo., 28. Jan. 2019 um
18:29 Uhr:

i set up a new local testnet with one validator node, then queried with
the following command:

gaiacli query staking validator

this returned commission.updateTime: 0001-01-01 00:00:00 which makes
sense to me because technically the commission info was never updated. i
suppose it could return null or the date of instantiation - but i'm not
sure this is an issue.

i made an SDK issue to see what the team thinks: cosmos/cosmos-sdk#3411
https://github.com/cosmos/cosmos-sdk/issues/3411

in the mean time, i will update the logic in the validator profile page to
display something sensible here instead of "2018 years ago" - and we can
see what comes of the SDK ticket.

—
You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
https://github.com/cosmos/voyager/issues/1737#issuecomment-458224559,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFmO2VdL9gr9exPKwKUUc1eUeC4iloOgks5vHzNbgaJpZM4ZNsHv
.