Lunie: Use 24 hr format for displaying time

[fedekunze]

Description:

Based on feedback from @cwgoes

[jbibla]

what is the thinking here @cwgoes @zramsay? something beyond preference?

[cwgoes]

I think 24-hour time is unambiguous and ought to be the preferred world format - it's definitely popular among our initial likely userbase.

However, as my preference may not be universally shared - it doesn't necessarily need to be the default - a configuration option would be nice.

[jbibla]

a configuration option would be nice

makes sense to me. maybe we can take this config from the browser.

[sabau]

Agree let's pick the system/browser preferences then eventually we can override them with some config

[sabau]

I would like to include in this also some fixes on time:

• sometimes we use Date instead of moment
• transaction.time seems not to be there for cosmos-sdk/Send transactions

[faboweb]

transaction.time seems not to be there for cosmos-sdk/Send transactions

transactions get enriched with time in Voyager (transaction module > enrichTransactions). transactions don't hold time. only block header information hold time.
This could/should move into stargate at some point.

[sabau]

Exactly,

• the type does not match, we are storing an ISO string, but the usages of them seems to like Number
• it seems to be null for some kind of transactions at least (just checked from develop)

totally agree on adding this before it hit the client

[faboweb]

Requested: https://github.com/cosmos/cosmos-sdk/issues/3238

[sabau]

in the meanwhile the cause of the missed enrichment was just another Type mismatch :)

heightsSet: {28, 25, "2", "5", "8"}