Lunie: Scrolling bug on TabMyDelegations

[fedekunze]

Description:

There's a scroll related bug on the TabMyDelegations page that displays an empty page (see screenshot).

Steps to reproduce (using yarn start with old testnet):

1. Go to Staking > tab Validators
2. Scroll all the way to the bottom of the validators index
3. Click tab My Delegations
4. Tab displays empty page

[fedekunze]

cc: @jbibla

[fedekunze]

we'll probably have to check this on other existing tabs as well

[jbibla]

do you know what the problem is?

my guess: the scroll position doesn't reset when changing routes.

[faboweb]

the scroll position doesn't reset when changing routes.

that was our guess as well

[fedekunze]

can't reproduce/fix on local testnet since we only have one validator

[faboweb]

You could use the mocked connection and edit lcdClientMock to have 50 validators

[jbibla]

it's not obvious to me why we need the perfect scroll plugin. can we remove it and rely on css?

[faboweb]

Can you ask @nylira why he added it in the first place? Maybe it serves a purpose.

[jbibla]

from @nylira: "it was to normalize the app design between multiple operating systems. For example, Windows and Linux have ugly default scrollbars that we cannot style. It also eats into the horizontal space of the app itself, as well as making scrolling popups and panels look not as great."

i would vote to remove it. i have no issue with native scrollbars and don't think we need this extra dependency.

i will also fix the bug reported in this issue.

[faboweb]

I remember that there was an issue on Windows with the scrollbar. Could you check there first before removing the plugin?

[jbibla]

I remember that there was an issue on Windows with the scrollbar. Could you check there first before removing the plugin?

i'm going to open a ticket to address this as it is a low priority refactor and requires much work to work properly without it.