Lunie: Undelegation tx still shows Claim button after click

[fedekunze]

Description:

I completed my undelegation to claim back the tokens and the undelegation tx still shows the Claim button.

Full error:

deliverTx failed: (262246) Msg 0 failed: 
=== ABCI Log ===
Codespace: 4
Code:      102
ABCICode:  262246
Error:    
   --= Error =--
      Data: common.FmtError{format:"no unbonding delegation found", args:[]interface {}(nil)}
      Msg Traces:
   --= /Error =-
-=== /ABCI Log ===

[NodeGuy]

I'm confused. Isn't the screenshot showing the error Ending undelegation failed, which means the undelegation didn't complete?

[fedekunze]

It completed (hence the Ended Unbonding tx) but it’s still showing the claim button, which when you click it again throws the error

[faboweb]

Scope:

• [ ] if clicking on the claim button, and the claim is successful, refreshing the UI should not show the claim button

[jbibla]

refreshing the UI should not show the claim button

can we start moving towards _not_ having to press the refresh button?

[faboweb]

refreshing the UI

this means in development -> when Voyager is restarted

can we start moving towards not having to press the refresh button?

this should be mostly the case already. I would leave a refresh button in there anyway to give users a sense of security.

[jbibla]

I would leave a refresh button in there anyway to give users a sense of security.

nooooooooo~~! we should remove them and have proper loading images on every screen and in every component.

[faboweb]

yes, plus a refresh option. which product do you know, that doesn't have a refresh option? I assume users would feel unsecure if the values they are seeing are the latest.

[jbibla]

browsers have a refresh option, i don't know any desktop or mobile apps that provide this. can you provide some example apps?

my expectation is that the data i see is always the most up to date. having to click refresh / reload is an indication that we are not providing enough information or feedback to our users. the impulse to click refresh on any of our pages will only happen if we aren't communicating what is happening and the users expectations are different from what has been communicated / displayed.

sometimes, software bugs out - so i would be in favour of command R refreshing Voyager but there should be no reason to provide a refresh button that is specific to a page or component.

[NodeGuy]

Total agreement with Jordan. 90% of apps don't have a refresh option and it's a design failure when they do, including browsers.

[faboweb]

What? Can you please go to inbox or Facebook and do a pull down to refresh?

David Braun [e-mail] schrieb am Do., 11. Okt. 2018, 20:24:

Total agreement with Jordan. 90% of apps don't have a refresh option and
it's a design failure when they do, including browsers.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/cosmos/voyager/issues/1410#issuecomment-429067114,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFmO2WJ9LChnwNRZGueeT0w1m_yB-Wm8ks5uj4zsgaJpZM4XH35_
.

[faboweb]

Well, in the apps.. My bad. But in the browser as you say, we have the
ability to refresh.

Fabian Weber [e-mail] schrieb am Do., 11. Okt. 2018 um
20:48 Uhr:

What? Can you please go to inbox or Facebook and do a pull down to refresh?

David Braun [e-mail] schrieb am Do., 11. Okt. 2018,
20:24:

Total agreement with Jordan. 90% of apps don't have a refresh option and
it's a design failure when they do, including browsers.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/cosmos/voyager/issues/1410#issuecomment-429067114,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFmO2WJ9LChnwNRZGueeT0w1m_yB-Wm8ks5uj4zsgaJpZM4XH35_
.

[jbibla]

ok you are kind of right. sometimes, you can "refresh" but this is more and more like requesting more data, not data that you should have been pushed already.

[NodeGuy]

Having to request more data in those situations is still a design wart.

[NodeGuy]

Blocked because @faboweb needs to publish the new version of tendermint/ui.

[cwgoes]

@NodeGuy Did you want anything from me here or was that an accidental assignment?

[NodeGuy]

@cwgoes It was an accident, sorry.

[faboweb]

published 0.3.1

[faboweb]

The unbonding delegation received from /stake/delegator/{addr} doesn't have a height associated. So we can't map transactions with active unbondingDelegations. Will check if this still is the case in the latest develop.