Lunie: "about" menu doesn't display unless logged in

Created on 15 Aug 2018  路  7Comments  路  Source: luniehq/lunie

i think we should use the native electron menu.

https://electronjs.org/docs/api/menu

bug

All 7 comments

This didn't worked properly on Windows/Linux. Maybe this was a bug and we can test this again.

i thought i remembered something about this. i would be surprised if electron hadn't solved this.

easy fix might be to set z-index on the menu higher then the session menu

yeah, but i think ideally it would be done the electron native way

Plan:
Easy fix: Increase the z-index of the about menu to show even when the sign in overlay is showing.
Sophisticated fix: Use the electron native menu for this (https://github.com/cosmos/voyager/issues/1201)

Update:
While the login screen is displaying, no other component is rendered. So the about menu is not rendered as well. So I think we need to do #1201

Closed in favor of #1201

Was this page helpful?
0 / 5 - 0 ratings