Lunie: Error fetching validator set

[NodeGuy]

UI Version: 0.9.3

Description:

Before I sign in, the error message "Error fetching validator set: Internal error" is displayed.

I don't see anything significant in either console.

[jbibla]

it's odd that we are making requests before the user is signed in

[nylira]

Can we turn session modals into pages in vue-router instead of a z-index overlay on top of the wallet?

[faboweb]

@nylira can you create an issue recommending this change?

[faboweb]

I think this is a strange typo issue /stake/validators/ vs /stake/validators and I experienced it as well in #1068 . It will hopefully be resolved after this is merged.

[faboweb]

Assumed fixed

[faboweb]

Still an issue

[NodeGuy]

What's blocking it?

[faboweb]

the blocking label was still on there

[NodeGuy]

I can't reproduce it. @faboweb are you able to reproduce it consistently?

[faboweb]

Not consistently but it happens from time to time.
"maybeUpdateValidators" is definitely called before having signed in. Which is probably OK to already fetch non user related data in the background.
I could imagine that this happens when we connect to a node and then quickly disconnect from that node again for any reason.

[NodeGuy]

So what's the desired behavior? Should getValidators be called only when connected to a node or should we suppress the error message?

[faboweb]

Both seem to be valid options. Maybe we need to defer REST calls a little bit, so we are sure the connected node is working and we wont reconnect. This would solve the root cause.

[faboweb]

I handle the case "skipping it" in #1216

[fedekunze]

Created #1313 to turn the session modals to pages

[faboweb]

The rpc subscription starts before the REST client is up. The headers come in and trigger a load of the validators before the the REST server is up. This creates this issue.

Current patch: Do not load data before the user is not signed in (which should be after the REST server is up).